Skip to content

Allow PHP 7.4#762

Merged
nWidart merged 2 commits intoAsgardCms:masterfrom
mikemand:hotfix/allow-php7.4
Sep 3, 2020
Merged

Allow PHP 7.4#762
nWidart merged 2 commits intoAsgardCms:masterfrom
mikemand:hotfix/allow-php7.4

Conversation

@mikemand
Copy link
Contributor

@mikemand mikemand commented Sep 1, 2020

Fixes #756.

Signed-off-by: Micheal Mand <micheal@kmdwebdesigns.com>
@nWidart
Copy link
Member

nWidart commented Sep 2, 2020

Thanks! Should this also add they 7.4 version in the travis version matrix maybe?
For some reason, travis has been failing due to memory issues :/

@mikemand
Copy link
Contributor Author

mikemand commented Sep 2, 2020

I can try that if you want, yeah. The memory issues are something Composer is doing. Probably something to do with how old the dependencies are...

Signed-off-by: Micheal Mand <micheal@kmdwebdesigns.com>
@nWidart
Copy link
Member

nWidart commented Sep 3, 2020

Thanks!

I see the builds started failing 4 months ago (30th April 2020).
I would be surprised if the fact of old dependencies could cause this 😱

@nWidart nWidart merged commit f12eef6 into AsgardCms:master Sep 3, 2020
@mikemand mikemand deleted the hotfix/allow-php7.4 branch September 3, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants