Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commented out unused variables #11

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Commented out unused variables #11

merged 3 commits into from
Jan 7, 2025

Conversation

akshayks13
Copy link
Contributor

@akshayks13 akshayks13 commented Jan 2, 2025 •
edited
Loading

In this PR , i have identified certain issues , and would like to share my insights

  • Commented on variables and function that are not being used in the code, indicating which can be removed without affecting functionality.
  • Removed extra blank spaces, aligned code, and enhanced structure to improve readability and maintain consistency.
  • Identified redundant conditions and unnecessary logic, adding comments to suggest potential simplifications and improvements.

I have not removed any part of the code, So you can say what to remove and what not to be removed.

Solved issue #8

@akshayks13 akshayks13 changed the title Commneted out unused variables Commented out unused variables Jan 2, 2025
@Ashrockzzz2003 Ashrockzzz2003 self-requested a review January 2, 2025 15:50
@Ashrockzzz2003 Ashrockzzz2003 linked an issue Jan 2, 2025 that may be closed by this pull request
Remove unused variables across codebase. #8
Closed
1 task
Ashrockzzz2003
Ashrockzzz2003 reviewed Jan 7, 2025
View reviewed changes
Copy link
Owner

@Ashrockzzz2003 Ashrockzzz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both null and empty checks required. It can be replaced with not(true) logic using typeof but that's for another PR.

LGTM

@Ashrockzzz2003 Ashrockzzz2003 self-requested a review January 7, 2025 09:18
@Ashrockzzz2003
Copy link
Owner

/bounty 60 @akshayks13

@Ashrockzzz2003 Ashrockzzz2003 merged commit 230bf4a into Ashrockzzz2003:v2 Jan 7, 2025
1 check passed
@akshayks13
Copy link
Contributor Author

Both null and empty checks required. It can be replaced with not(true) logic using typeof but that's for another PR.

LGTM

Oh fine na , I thought it was redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashrockzzz2003 Ashrockzzz2003 Ashrockzzz2003 approved these changes

Assignees

@akshayks13 akshayks13

Labels
AMWOC AMWOC-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused variables across codebase.
2 participants
@akshayks13 @Ashrockzzz2003