Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Remaining Peer Protocol Features #31

Merged
merged 92 commits into from
Dec 16, 2023

Fix infinite recursion

ce3c869
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Implement Remaining Peer Protocol Features #31

Fix infinite recursion
ce3c869
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana Community for JVM completed Dec 16, 2023 in 0s

4 new problems found by Qodana Community for JVM

Qodana Community for JVM

4 new problems were found

Inspection name Severity Problems
Result of method call ignored 🔶 Warning 2
Nullability and data flow problems 🔶 Warning 1
Optional.get() is called without isPresent() check 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 66 in src/main/java/jtorrent/common/domain/util/RateTracker.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems

Dereference of `queue.peek()` may produce `NullPointerException`

Check warning on line 414 in src/main/java/jtorrent/torrent/domain/handler/TorrentHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Result of method call ignored

Result of `LinkedBlockingQueue.remove()` is ignored

Check warning on line 66 in src/main/java/jtorrent/torrent/presentation/UiTorrent.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Result of method call ignored

Result of `Observable.subscribe()` is ignored

Check warning on line 520 in src/main/java/jtorrent/torrent/domain/handler/TorrentHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Optional.get() is called without isPresent() check

`OptionalInt.getAsInt()` without 'isPresent()' check