New UI #33
Merged
New UI #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove callback setters - Perform binding logic in setViewModel() method instead
- Update torrents list on JavaFX Application Thread - Dispose torrents and clear maps when clear event is received
This will ensure that subscribers immediately receive an update in case there are no underlying sources currently
Relative path to source should be passed into BencodedFile.fromPath()
Shift io logic out of Bencoded models into FileTorrentRepository
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // only works on windows. Doing this because Desktop::browseFileDirectory doesn't work on Windows 10 | ||
| final String command = EXPLORER_EXE + " /SELECT,\"" + torrent.getSaveAsPath().toAbsolutePath() + "\""; | ||
| try { | ||
| Runtime.getRuntime().exec(command); |
Check failure
Code scanning / CodeQL
Building a command line with string concatenation Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.