Merge pull request #2009 from kylemhall/issue_2008

Fix query to select circulation rules for Koha #2008

code/web/Drivers/Koha.php

@@ -539,12 +539,17 @@ public function getCheckouts(User $patron): array {
 				$circulationRulesForCheckout = [];
 				/** @noinspection SqlResolve */
 				/** @noinspection SqlDialectInspection */
-				$circulationRulesSql = "SELECT *  FROM circulation_rules where (categorycode IN ('$patronType', '*') OR categorycode IS NULL) and (itemtype IN('$itemType', '*') OR itemtype is null) and (branchcode IN ('$checkoutBranch', '*') OR branchcode IS NULL) order by branchcode desc, categorycode desc, itemtype desc";
+				$circulationRulesSql = "
+					SELECT * FROM circulation_rules
+					WHERE (categorycode IN ('$patronType', '*') OR categorycode IS NULL)
+					  AND (itemtype IN('$itemType', '*') OR itemtype is null)
+					  AND (branchcode IN ('$checkoutBranch', '*') OR branchcode IS NULL)
+					ORDER BY branchcode desc, categorycode desc, itemtype desc LIMIT 1
+				";
 				$circulationRulesRS = mysqli_query($this->dbConnection, $circulationRulesSql);
 				if ($circulationRulesRS !== false) {
-					while ($circulationRulesRow = $circulationRulesRS->fetch_assoc()) {
-						$circulationRulesForCheckout[] = $circulationRulesRow;
-					}
+					$circulationRulesRow = $circulationRulesRS->fetch_assoc();
+					$circulationRulesForCheckout[] = $circulationRulesRow;
 					$circulationRulesRS->close();
 				}
 				$timer->logTime("Load circulation rules for checkout");

code/web/release_notes/24.09.00.MD

@@ -142,6 +142,7 @@
 - Remove superfluous loop in Koha driver function updateHomeLibrary #1968 (*KMH*)
 - Hide empty item groups for volume-level holds in Koha (*KMH*)
 - Remove old pre-production Koha volumes code (*KMH*)
+- Fix query to select circulation rules for Koha (*KMH*)
 
 ### GitHub Actions
 - Add GitHub Actions to check pull requests for release notes (*KMH*)