Manage request fixes when there are no locations for a library

Aspen-Discovery · Jan 14, 2025 · cc91a1d · cc91a1d
1 parent cacb053
commit cc91a1d
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/code/web/services/MaterialsRequest/ManageRequests.php b/code/web/services/MaterialsRequest/ManageRequests.php
@@ -236,14 +236,14 @@ function launch() : void {
 				while ($rolePermissions->fetch()) {
 					// Get Available Assignees
 					$materialsRequestManagers = new User();
-
-					if ($materialsRequestManagers->query("SELECT * from user WHERE id IN (SELECT userId FROM user_roles WHERE roleId = $rolePermissions->roleId) AND homeLocationId IN (" . implode(', ', $locationsForLibrary) . ")")) {
-
-						while ($materialsRequestManagers->fetch()) {
-							if (empty($materialsRequestManagers->displayName)) {
-								$assignees[$materialsRequestManagers->id] = $materialsRequestManagers->firstname . ' ' . $materialsRequestManagers->lastname;
-							} else {
-								$assignees[$materialsRequestManagers->id] = $materialsRequestManagers->getDisplayName();
+					if (count($locationsForLibrary) > 0) {
+						if ($materialsRequestManagers->query("SELECT * from user WHERE id IN (SELECT userId FROM user_roles WHERE roleId = $rolePermissions->roleId) AND homeLocationId IN (" . implode(', ', $locationsForLibrary) . ")")) {
+							while ($materialsRequestManagers->fetch()) {
+								if (empty($materialsRequestManagers->displayName)) {
+									$assignees[$materialsRequestManagers->id] = $materialsRequestManagers->firstname . ' ' . $materialsRequestManagers->lastname;
+								} else {
+									$assignees[$materialsRequestManagers->id] = $materialsRequestManagers->getDisplayName();
+								}
 							}
 						}
 					}