- Correct showing material requests when the active library has no lo…

…cations
Aspen-Discovery · Jan 14, 2025 · f4ed3ba · f4ed3ba
1 parent 68ec744
commit f4ed3ba
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/code/web/release_notes/25.01.00.MD b/code/web/release_notes/25.01.00.MD
@@ -94,6 +94,9 @@
 
 </div>
 
+### Materials Request Updates
+- Correct showing material requests when the active library has no locations. (*MDN*)
+
 ### Polaris Updates
 - Automatically import sublocations from Polaris. (DIS-46) (*MDN*)
 - Set hold pickup area when sublocations are being used while placing holds. (DIS-46) (*MDN*)
@@ -175,6 +178,11 @@
 - Alyssa Drake (ByWater Solutions)
 - Myranda Fuentes (Grove)
 - Bryan Jones (Nashville Public Library)
+- Jordan Fields (Grove)
+
+## Special Documentation thanks to
+- Myranda Fuentes (Grove)
+- Jordan Fields (Grove)
 
 ## This release includes sponsored developments from
 - Greater Manchester Inter Library Consortial System (GMILCS)

diff --git a/code/web/services/MaterialsRequest/ManageRequests.php b/code/web/services/MaterialsRequest/ManageRequests.php
@@ -137,7 +137,9 @@ function launch() : void {
 				$locationsForLibrary[] = $locations->locationId;
 			}
 
-			$materialsRequests->whereAdd('user.homeLocationId IN (' . implode(', ', $locationsForLibrary) . ')');
+			if (count($locationsForLibrary) > 0) {
+				$materialsRequests->whereAdd('user.homeLocationId IN (' . implode(', ', $locationsForLibrary) . ')');
+			}
 
 			if (count($availableStatuses) > count($statusesToShow)) {
 				$materialsRequests->whereAddIn('status', $statusesToShow, false);