For GitHub Actions only attempt to log in and push to container repos if the commit is pushed to the official repo #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ushed to the official repo When a developer pushes a branch of Aspen Discovery to their own repo to create a pull request, it triggers the building of Docker images. The building of the images itself is good to find issues in the build process, but the actions fail because the the actions can only log in on the official repo. This change resolves this be only logging in to the registries if the commit is pushed to the official repo, while still allowing the docker images to be build for testing purposes.
kylemhall
force-pushed
the
fix_github_actions_docker
branch
from
dc03c0d to
968e086
Compare
mdnoble73
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a developer pushes a branch of Aspen Discovery to their own repo to create a pull request, it triggers the building of Docker images. The building of the images itself is good to find issues in the build process, but the actions fail because the the actions can only log in on the official repo.
This change resolves this be only logging in to the registries if the commit is pushed to the official repo, while still allowing the docker images to be build for testing purposes.
You can see it working successfully in my personal repo: https://github.com/kylemhall/aspen-discovery/actions/runs/10510807021