DIS-211: Ignore 'number one bestseller' subtitle in OverDrive #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to list
When saving to a list, Aspen saves the title in the user_list_entry table, shortening it to 50 characters
For a title like:
Just being Dalí : the story of artist Salvador Dalí / by Amy Guglielmo ; illustrated by Brett Helquist.
When punctuation removed and string shortened we get:
just being dalí the story of artist salvador dalí
The 50th character being: í
When using substr - the diacritic is cut in half, the string is mangled, and the title can fail to save to the DB
When using mb_substr - the diacritic is preserved
This patch converts all the substr in the file to mb_substr as it is the safer option when using UTF8
To test:
1 - In Koha add the title "Just being Dalí : the story of artist Salvador Dalí / by Amy Guglielmo ; illustrated by Brett Helquist."
You can grab from LOC via Z39.50
2 - Wait for Aspen to index
3 - Find the title in Aspen, add to a list
4 - Confirmation box appears, but list does not contain title when checked
5 - Apply patch
6 - Repeat
7 - Title successfully added
DIS-178 - Use mb_substr to preserve diacritics
LeoStoyanovByWater
changed the title
|
Hi @LeoStoyanovByWater could you resubmit this against version 25.02? Thanks,
|
LeoStoyanovByWater
force-pushed
the
DIS-211-ignore-number-one-bestseller
branch
from
73c3a7a to
aeed92b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that promotional subtitles like "number one bestsellers" are filtered out in when searching OverDrive records.