25.01.00 restore ebsco searchers #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to run a search in 'Articles and Databases' using the EBSCO EDS or host integration, the attempt to display the results fails, and the following error message is displayed instead: SearchObject_EbscoEdsSearcher::processSearch(): Return value must be of type AspenError|array|null , stdClass returned For EBSCO host, the same error appear, but the data type mentioned is SimpleXMLElement. This bug was introduced in 25.01.00. This patch adds stdClass to the list of valid return types, restoring functionality to the EBSCO EDS and host integration. note: valid EBSCO EDS and host credentials are required To replicate: - checkout to a 25.01.00-based branch - enable the EBSCO EDS / host module - create an EBSCO EDS / host setting - run a search in 'Article and Databases' - notice that EBSCO EDS / host search results do not display - notice the error message Test plan: - apply this patch - run a search in 'Article and Databases' - notice that EBSCO EDS / host search results display normally
…earcher 25.01.00 restore ebsco eds and host searcher
mdnoble73
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that prevents patrons form searching in 'Article Databases' when Aspen Discovery is set to use the EBSCO EDS or EBSCO host integrations.
Detailed description in the Jira ticket: https://aspen-discovery.atlassian.net/browse/DIS-221
Test plan in commit messages