Dis 92 add feedback when saving grapes page #2194
Open
+232
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a message when saving a grapes template and grapes page. Improve messages when errors occur.
…_When_Saving_Grapes_Page feat: Add message for template and page save
mdnoble73
requested changes
Jan 14, 2025
code/web/interface/themes/responsive/WebBuilder/createTemplatejs.tpl
Outdated
Show resolved
Hide resolved
Update success and error messages displayed on save to be translatable
…_When_Saving_Grapes_Page refactor: Update success and error save messages
Update success and error messages displayed on save to be translatable
…_When_Saving_Grapes_Page refactor: Update success and error save messages
|
Thanks Mark, I have added translatable templates and swapped to a var instead of a let. |
Add a check to ensure user is logged in before they can save a grapes template or page.
…_When_Saving_Grapes_Page Dis 92 add feedback when saving grapes page
…2-Add_Feedback_When_Saving_Grapes_Page
…_When_Saving_Grapes_Page Dis 92 add feedback when saving grapes page
…_When_Saving_Grapes_Page refactor: Alter check to use active user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://aspen-discovery.atlassian.net/jira/software/c/projects/DIS/boards/2?search=92&selectedIssue=DIS-92
This commit adds feedback in the form of a message when a grapes page is saved.