Dis 226 fix save url to link image to on web builder portal cells #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the /WebBuilder/PortalRows page, the 'URL to link image to' cannot be saved. To resolve this an $imageURL property needs to be added to the PortalCell class, as this exists as a field in the web_builder_portal_cell table, which is where the value to assign to the URL to link image to is pulled from. Test plan: see Jira ticket DIS-194 and follow the steps 1 - 7 in the test plan. following this: 8. Image action choice will be preserved but the 'URL to link image to' field will not show immediately upon page reload 9. Upon selecting Image action again, 'URL to link image to' will contain the previously entered value. 10. On the Custom Web Builder Pages, select 'View' 11. Notice that clicking on the image will redirect the user to the 'URL to link image to'.
…_img_url 25.02.00 fix webbuilder save img url
mdnoble73
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket https://aspen-discovery.atlassian.net/browse/DIS-226
(is a subtask of https://aspen-discovery.atlassian.net/browse/DIS-194)
Test plan on the Jira subtask