DIS-397 Add logging to INN-Reach results fetch method #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds * logging of the external request made to INN-Reach, through `ExternalRequestLogEntry::logRequest` * a check for the HTTP response status code, and if it is not 200, an error log will be generated Test plan: 1. Enable the INN-Reach integration 2. Have random credentials for the OAuth2 section 3. Perform a search 4. Make sure your IP gets external requests logged => An error log should be generated => There's a log on the external requests logs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
ExternalRequestLogEntry::logRequestTest plan:
=> There's a log on the external requests logs