Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-397 Add logging to INN-Reach results fetch method #2250

Open
wants to merge 1 commit into
base: 25.03.00
Choose a base branch
from

Conversation

tomascohen
Copy link
Contributor

This patch adds

  • logging of the external request made to INN-Reach, through ExternalRequestLogEntry::logRequest
  • a check for the HTTP response status code, and if it is not 200, an error log will be generated

Test plan:

  1. Enable the INN-Reach integration
  2. Have random credentials for the OAuth2 section
  3. Perform a search
  4. Make sure your IP gets external requests logged => An error log should be generated
    => There's a log on the external requests logs

This patch adds

* logging of the external request made to INN-Reach, through
  `ExternalRequestLogEntry::logRequest`
* a check for the HTTP response status code, and if it is not 200, an
  error log will be generated

Test plan:
1. Enable the INN-Reach integration
2. Have random credentials for the OAuth2 section
3. Perform a search
4. Make sure your IP gets external requests logged
=> An error log should be generated
=> There's a log on the external requests logs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
@tomascohen
Copy link
Contributor Author

For the record, I ran the QA bash script lines locally and cannot reproduce the error tabs vs. spaces error. Any advise is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant