fix #2727 Type checker does not detect a signature mismatch #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changqing-JING
changed the title
MaxGraey
reviewed
Jul 29, 2023
Changqing-JING
force-pushed
the
bugfix/2727
branch
from
cea03b7
to
eb7b4c2
Compare
CountBleck
reviewed
Jul 29, 2023
|
@MaxGraey All checks passed, can is PR be approved? |
This comment was marked as resolved.
This comment was marked as resolved.
|
This test case expect a compiler failed error. It can't emit wat file |
Changqing-JING
force-pushed
the
bugfix/2727
branch
4 times, most recently
from
d5fc165
to
cbe74d6
Compare
Changqing-JING
force-pushed
the
bugfix/2727
branch
from
cbe74d6
to
0055da6
Compare
CountBleck
requested changes
Jul 31, 2023
CountBleck
added a commit
to CountBleck/assemblyscript
that referenced
this pull request
Jul 31, 2023
In most cases, a function type is assignable to another if the target `this` parameter is a subtype of the original `this` parameter. However, this check wasn't performed correctly in `Signature#isAssignableTo`. Also, the reverse is true when checking whether override signatures are compatible, since the `this` parameter refers to the subclass that's overriding the parent class's method. At least, that's how I think it works... Fixes AssemblyScript#2727. Closes AssemblyScript#2728.
CountBleck
added a commit
to CountBleck/assemblyscript
that referenced
this pull request
Jul 31, 2023
In most cases, a function type is assignable to another if the target `this` parameter is a subtype of the original `this` parameter. However, this check wasn't performed correctly in `Signature#isAssignableTo`. Also, the reverse is true when checking whether override signatures are compatible, since the `this` parameter refers to the subclass that's overriding the parent class's method. At least, that's how I think it works... Fixes AssemblyScript#2727. Closes AssemblyScript#2728.
CountBleck
added a commit
to CountBleck/assemblyscript
that referenced
this pull request
Jul 31, 2023
In most cases, a function type is assignable to another if the target `this` parameter is a subtype of the original `this` parameter. However, this check wasn't performed correctly in `Signature#isAssignableTo`. Also, the reverse is true when checking whether override signatures are compatible, since the `this` parameter refers to the subclass that's overriding the parent class's method. At least, that's how I think it works... Fixes AssemblyScript#2727. Closes AssemblyScript#2728.
CountBleck
requested changes
Aug 1, 2023
CountBleck
reviewed
Aug 2, 2023
Changqing-JING
force-pushed
the
bugfix/2727
branch
from
b386305
to
b74c7de
Compare
HerrCai0907
approved these changes
Sep 28, 2023
It might be redundant, since the same code path is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2727