Implement average exposure effect #603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scopesim has always produced output that was the sum over ndit subexposures. Many/most instruments produce averages, and this will likely be the case for METIS and MICADO. This PR implements an effect
ExposureOutput
, which takes an argumentmode
, which can be eitheraverage
orsum
. It should come after the detector noise effects, all of which assume a summed exposure. Unfortunately, this means that currently bothSummedExposure
(before the detector noises) andExposureOutput
need to be in effects chain. Since the former has no user-settable parameters it might actually be integrated into thereadout()
method and disappear from view.I couldn't resist giving the effect a
set_mode()
method for user convenience.So far, the effect is only set in METIS img_lm, cf. AstarVienna/irdb#224