Skip to content

Implement average exposure effect #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Implement average exposure effect #603

merged 3 commits into from
Mar 25, 2025

Conversation

oczoske
Copy link
Collaborator

@oczoske oczoske commented Mar 24, 2025

Scopesim has always produced output that was the sum over ndit subexposures. Many/most instruments produce averages, and this will likely be the case for METIS and MICADO. This PR implements an effect ExposureOutput, which takes an argument mode, which can be either average or sum. It should come after the detector noise effects, all of which assume a summed exposure. Unfortunately, this means that currently both SummedExposure (before the detector noises) and ExposureOutput need to be in effects chain. Since the former has no user-settable parameters it might actually be integrated into the readout() method and disappear from view.
I couldn't resist giving the effect a set_mode() method for user convenience.

So far, the effect is only set in METIS img_lm, cf. AstarVienna/irdb#224

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.76%. Comparing base (6cb80a7) to head (cc68b3f).
Report is 269 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   76.68%   76.76%   +0.07%     
==========================================
  Files          69       69              
  Lines        8536     8563      +27     
==========================================
+ Hits         6546     6573      +27     
  Misses       1990     1990              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg moved this from 🆕 New to 👀 Awaiting Review in ScopeSim-development Mar 24, 2025
@teutoburg teutoburg added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) effects Related to a ScopeSim effect tests Related to unit or integration tests labels Mar 24, 2025
@teutoburg teutoburg linked an issue Mar 25, 2025 that may be closed by this pull request
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for now 👍

@oczoske oczoske merged commit 2a87370 into main Mar 25, 2025
39 of 40 checks passed
@oczoske oczoske deleted the oc/exposureaction branch March 25, 2025 14:51
@github-project-automation github-project-automation bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) tests Related to unit or integration tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable averaged exposures
2 participants