Skip to content

fix: remove unnecessary margins from v-main for consistent layout#7481

Open
Saramanda9988 wants to merge 2 commits intoAstrBotDevs:masterfrom
Saramanda9988:fix-style
Open

fix: remove unnecessary margins from v-main for consistent layout#7481
Saramanda9988 wants to merge 2 commits intoAstrBotDevs:masterfrom
Saramanda9988:fix-style

Conversation

@Saramanda9988
Copy link
Copy Markdown

@Saramanda9988 Saramanda9988 commented Apr 12, 2026

Modifications / 改动点

问题来自 dashboard/src/scss/layout/_container.scss 中根布局 .v-main 的固定右外边距。

这个额外的外边距会把背景色显露出来,因此视觉上看起来像右侧多了一条边框,在深色模式下比较明显,且似乎没有具体的作用

image image image

修改为无额外边距,保证视觉一致性

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

505fcf849207b902c134d88d54aa08f4

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Remove extra margins from the main layout container to align content consistently with the background across viewports.

Bug Fixes:

  • Eliminate the fixed right margin on the main layout to prevent an unintended visible strip at the page edge, especially in dark mode.

Enhancements:

  • Standardize the .v-main container margins to zero for consistent layout spacing on both desktop and smaller screens.

@auto-assign auto-assign bot requested review from Fridemn and advent259141 April 12, 2026 08:56
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 12, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since .v-main now has the same margin: 0 rule for both default and @media (max-width: 1279px), consider removing the redundant media-query override or only keeping it if you expect different margins again in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `.v-main` now has the same `margin: 0` rule for both default and `@media (max-width: 1279px)`, consider removing the redundant media-query override or only keeping it if you expect different margins again in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SCSS layout by setting the margin of the .v-main container to zero. A review comment suggests removing a redundant media query block, as the base style now covers the margin requirement for all screen sizes.

@dosubot dosubot bot added the area:webui The bug / feature is about webui(dashboard) of astrbot. label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant