Skip to content

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Sep 27, 2025

Copy link

github-actions bot commented Sep 27, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@boydaihungst

This comment was marked as resolved.

@Uzaaft
Copy link
Member Author

Uzaaft commented Sep 28, 2025

There is a reason this PR is in draft @boydaihungst

@Uzaaft Uzaaft changed the title refactor(diff-keybindings): Refactor diffkeybindings to use astroui, … fix(diff-keybindings): Refactor diffkeybindings to use astroui, and fix visual bug Oct 1, 2025
@Uzaaft Uzaaft marked this pull request as ready for review October 1, 2025 08:23
Uzaaft and others added 2 commits October 3, 2025 11:47
Co-authored-by: Anton Ždanov <anton@azdanov.dev>
Co-authored-by: Anton Ždanov <anton@azdanov.dev>
@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 3, 2025

Good catches @azdanov

@Uzaaft Uzaaft merged commit 35e50cf into main Oct 3, 2025
16 checks passed
@Uzaaft Uzaaft deleted the refactor/diff branch October 3, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants