Skip to content

threading

threading #4

GitHub Actions / clippy failed Dec 14, 2024 in 1s

clippy

20 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 20
Warning 0
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check failure on line 133 in unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_writer, 'asset

error: the following explicit lifetimes could be elided: 'parent_writer, 'asset
   --> unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs:133:6
    |
133 | impl<'parent_writer, 'asset, W: ArchiveWriter<PackageIndex>> Seek
    |      ^^^^^^^^^^^^^^  ^^^^^^
134 |     for UsmapWriter<'parent_writer, 'asset, W>
    |                     ^^^^^^^^^^^^^^  ^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
133 ~ impl<W: ArchiveWriter<PackageIndex>> Seek
134 ~     for UsmapWriter<'_, '_, W>
    |

Check failure on line 121 in unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_writer, 'asset

error: the following explicit lifetimes could be elided: 'parent_writer, 'asset
   --> unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs:121:6
    |
121 | impl<'parent_writer, 'asset, W: ArchiveWriter<PackageIndex>> Write
    |      ^^^^^^^^^^^^^^  ^^^^^^
122 |     for UsmapWriter<'parent_writer, 'asset, W>
    |                     ^^^^^^^^^^^^^^  ^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
121 ~ impl<W: ArchiveWriter<PackageIndex>> Write
122 ~     for UsmapWriter<'_, '_, W>
    |

Check failure on line 115 in unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_writer, 'asset

error: the following explicit lifetimes could be elided: 'parent_writer, 'asset
   --> unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs:115:6
    |
115 | impl<'parent_writer, 'asset, W: ArchiveWriter<PackageIndex>> ArchiveWriter<PackageIndex>
    |      ^^^^^^^^^^^^^^  ^^^^^^
116 |     for UsmapWriter<'parent_writer, 'asset, W>
    |                     ^^^^^^^^^^^^^^  ^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
115 ~ impl<W: ArchiveWriter<PackageIndex>> ArchiveWriter<PackageIndex>
116 ~     for UsmapWriter<'_, '_, W>
    |

Check failure on line 40 in unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_writer, 'asset

error: the following explicit lifetimes could be elided: 'parent_writer, 'asset
  --> unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs:40:6
   |
40 | impl<'parent_writer, 'asset, W: ArchiveWriter<PackageIndex>> ArchiveTrait<PackageIndex>
   |      ^^^^^^^^^^^^^^  ^^^^^^
41 |     for UsmapWriter<'parent_writer, 'asset, W>
   |                     ^^^^^^^^^^^^^^  ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
40 ~ impl<W: ArchiveWriter<PackageIndex>> ArchiveTrait<PackageIndex>
41 ~     for UsmapWriter<'_, '_, W>
   |

Check failure on line 31 in unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_writer, 'asset

error: the following explicit lifetimes could be elided: 'parent_writer, 'asset
  --> unreal_asset/unreal_asset_base/src/unversioned/usmap_writer.rs:31:6
   |
31 | impl<'parent_writer, 'asset, W: ArchiveWriter<PackageIndex>>
   |      ^^^^^^^^^^^^^^  ^^^^^^
32 |     UsmapWriter<'parent_writer, 'asset, W>
   |                 ^^^^^^^^^^^^^^  ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
31 ~ impl<W: ArchiveWriter<PackageIndex>>
32 ~     UsmapWriter<'_, '_, W>
   |

Check failure on line 151 in unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_reader, 'asset

error: the following explicit lifetimes could be elided: 'parent_reader, 'asset
   --> unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs:151:6
    |
151 | impl<'parent_reader, 'asset, R: ArchiveReader<PackageIndex>> Seek
    |      ^^^^^^^^^^^^^^  ^^^^^^
152 |     for UsmapReader<'parent_reader, 'asset, R>
    |                     ^^^^^^^^^^^^^^  ^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
151 ~ impl<R: ArchiveReader<PackageIndex>> Seek
152 ~     for UsmapReader<'_, '_, R>
    |

Check failure on line 143 in unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_reader, 'asset

error: the following explicit lifetimes could be elided: 'parent_reader, 'asset
   --> unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs:143:6
    |
143 | impl<'parent_reader, 'asset, R: ArchiveReader<PackageIndex>> Read
    |      ^^^^^^^^^^^^^^  ^^^^^^
144 |     for UsmapReader<'parent_reader, 'asset, R>
    |                     ^^^^^^^^^^^^^^  ^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
143 ~ impl<R: ArchiveReader<PackageIndex>> Read
144 ~     for UsmapReader<'_, '_, R>
    |

Check failure on line 137 in unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_reader, 'asset

error: the following explicit lifetimes could be elided: 'parent_reader, 'asset
   --> unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs:137:6
    |
137 | impl<'parent_reader, 'asset, R: ArchiveReader<PackageIndex>> ArchiveReader<PackageIndex>
    |      ^^^^^^^^^^^^^^  ^^^^^^
138 |     for UsmapReader<'parent_reader, 'asset, R>
    |                     ^^^^^^^^^^^^^^  ^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
137 ~ impl<R: ArchiveReader<PackageIndex>> ArchiveReader<PackageIndex>
138 ~     for UsmapReader<'_, '_, R>
    |

Check failure on line 62 in unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'parent_reader, 'asset

error: the following explicit lifetimes could be elided: 'parent_reader, 'asset
  --> unreal_asset/unreal_asset_base/src/unversioned/usmap_reader.rs:62:6
   |
62 | impl<'parent_reader, 'asset, R: ArchiveReader<PackageIndex>> ArchiveTrait<PackageIndex>
   |      ^^^^^^^^^^^^^^  ^^^^^^
63 |     for UsmapReader<'parent_reader, 'asset, R>
   |                     ^^^^^^^^^^^^^^  ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
62 ~ impl<R: ArchiveReader<PackageIndex>> ArchiveTrait<PackageIndex>
63 ~     for UsmapReader<'_, '_, R>
   |

Check failure on line 135 in unreal_asset/unreal_asset_base/src/types/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty lines after doc comment

error: empty lines after doc comment
   --> unreal_asset/unreal_asset_base/src/types/mod.rs:125:1
    |
125 | / /// Create a Guid from 4 u32 values
126 | | // #[rustfmt::skip]
127 | | // pub const fn new_guid(a: u32, b: u32, c: u32, d: u32) -> Guid {
128 | | //     Guid
...   |
134 | | // }
135 | |
    | |_
...
138 |   pub struct GenerationInfo {
    |   ------------------------- the comment documents this struct
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
    = help: if the empty lines are unintentional remove them
help: if the doc comment should not document `GenerationInfo` comment it out
    |
125 ~ // /// Create a Guid from 4 u32 values
126 | // #[rustfmt::skip]
...
130 |
131 ~ // /// Create a default Guid filled with all zeros
    |

Check failure on line 158 in unreal_asset/unreal_asset_base/src/reader/raw_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'cursor

error: the following explicit lifetimes could be elided: 'cursor
   --> unreal_asset/unreal_asset_base/src/reader/raw_writer.rs:158:6
    |
158 | impl<'cursor, Index: PackageIndexTrait, W: Write + Seek> Seek for RawWriter<'cursor, Index, W> {
    |      ^^^^^^^                                                                ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
158 - impl<'cursor, Index: PackageIndexTrait, W: Write + Seek> Seek for RawWriter<'cursor, Index, W> {
158 + impl<Index: PackageIndexTrait, W: Write + Seek> Seek for RawWriter<'_, Index, W> {
    |

Check failure on line 148 in unreal_asset/unreal_asset_base/src/reader/raw_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'cursor

error: the following explicit lifetimes could be elided: 'cursor
   --> unreal_asset/unreal_asset_base/src/reader/raw_writer.rs:148:6
    |
148 | impl<'cursor, Index: PackageIndexTrait, W: Write + Seek> Write for RawWriter<'cursor, Index, W> {
    |      ^^^^^^^                                                                 ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
148 - impl<'cursor, Index: PackageIndexTrait, W: Write + Seek> Write for RawWriter<'cursor, Index, W> {
148 + impl<Index: PackageIndexTrait, W: Write + Seek> Write for RawWriter<'_, Index, W> {
    |

Check failure on line 132 in unreal_asset/unreal_asset_base/src/reader/raw_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'cursor

error: the following explicit lifetimes could be elided: 'cursor
   --> unreal_asset/unreal_asset_base/src/reader/raw_writer.rs:132:6
    |
132 | impl<'cursor, Index: PackageIndexTrait, W: Write + Seek> ArchiveWriter<Index>
    |      ^^^^^^^
133 |     for RawWriter<'cursor, Index, W>
    |                   ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
132 ~ impl<Index: PackageIndexTrait, W: Write + Seek> ArchiveWriter<Index>
133 ~     for RawWriter<'_, Index, W>
    |

Check failure on line 60 in unreal_asset/unreal_asset_base/src/reader/raw_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'cursor

error: the following explicit lifetimes could be elided: 'cursor
  --> unreal_asset/unreal_asset_base/src/reader/raw_writer.rs:60:6
   |
60 | impl<'cursor, Index: PackageIndexTrait, W: Write + Seek> ArchiveTrait<Index>
   |      ^^^^^^^
61 |     for RawWriter<'cursor, Index, W>
   |                   ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
60 ~ impl<Index: PackageIndexTrait, W: Write + Seek> ArchiveTrait<Index>
61 ~     for RawWriter<'_, Index, W>
   |

Check failure on line 556 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'map

error: the following explicit lifetimes could be elided: 'map
   --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:556:6
    |
556 | impl<'map, K, V> DoubleEndedIterator for Keys<'map, K, V>
    |      ^^^^                                     ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
556 - impl<'map, K, V> DoubleEndedIterator for Keys<'map, K, V>
556 + impl<K, V> DoubleEndedIterator for Keys<'_, K, V>
    |

Check failure on line 517 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'map

error: the following explicit lifetimes could be elided: 'map
   --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:517:6
    |
517 | impl<'map, K, V> DoubleEndedIterator for ValuesMut<'map, K, V>
    |      ^^^^                                          ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
517 - impl<'map, K, V> DoubleEndedIterator for ValuesMut<'map, K, V>
517 + impl<K, V> DoubleEndedIterator for ValuesMut<'_, K, V>
    |

Check failure on line 472 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'map

error: the following explicit lifetimes could be elided: 'map
   --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:472:6
    |
472 | impl<'map, K, V> DoubleEndedIterator for Values<'map, K, V>
    |      ^^^^                                       ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
472 - impl<'map, K, V> DoubleEndedIterator for Values<'map, K, V>
472 + impl<K, V> DoubleEndedIterator for Values<'_, K, V>
    |

Check failure on line 262 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'map

error: the following explicit lifetimes could be elided: 'map
   --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:262:6
    |
262 | impl<'map, K, V> DoubleEndedIterator for IndexedMapIndexIteratorMut<'map, K, V>
    |      ^^^^                                                           ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
262 - impl<'map, K, V> DoubleEndedIterator for IndexedMapIndexIteratorMut<'map, K, V>
262 + impl<K, V> DoubleEndedIterator for IndexedMapIndexIteratorMut<'_, K, V>
    |

Check failure on line 197 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'map

error: the following explicit lifetimes could be elided: 'map
   --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:197:6
    |
197 | impl<'map, K, V> DoubleEndedIterator for IndexedMapIndexIterator<'map, K, V>
    |      ^^^^                                                        ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
    |
197 - impl<'map, K, V> DoubleEndedIterator for IndexedMapIndexIterator<'map, K, V>
197 + impl<K, V> DoubleEndedIterator for IndexedMapIndexIterator<'_, K, V>
    |

Check failure on line 180 in unreal_asset/unreal_asset_base/src/unversioned/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

elided lifetime has a name

error: elided lifetime has a name
   --> unreal_asset/unreal_asset_base/src/unversioned/mod.rs:180:14
    |
177 |     pub fn get_all_properties<'name>(
    |                               ----- lifetime `'name` declared here
...
180 |     ) -> Vec<&UsmapProperty> {
    |              ^ this elided lifetime gets resolved as `'name`
    |
    = note: `-D elided-named-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`