Skip to content

Sourcery refactored master branch #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jan 6, 2022

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from closedLoop January 6, 2022 13:35
@pytest.fixture(
scope="function",
params=[
(
"s3pypi",
[
@pytest.fixture(scope="function", params=[("s3pypi", [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function index_html refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jan 6, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.06%.

Quality metrics Before After Change
Complexity 0.43 ⭐ 0.43 ⭐ 0.00
Method Length 46.67 ⭐ 46.33 ⭐ -0.34 👍
Working memory 8.86 🙂 8.86 🙂 0.00
Quality 79.48% 79.54% 0.06% 👍
Other metrics Before After Change
Lines 42 33 -9
Changed files Quality Before Quality After Quality Change
tests/unit/test_index.py 79.48% ⭐ 79.54% ⭐ 0.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/unit/test_index.py index_html 1 ⭐ 99 🙂 14 😞 61.53% 🙂 Extract out complex expressions
            ## Legend and Explanation

            The emojis denote the absolute quality of the code:

             - ⭐ excellent
             - 🙂 good
             - 😞 poor
             - ⛔ very poor


            The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

            ***

            Please see our documentation [here](https://docs.sourcery.ai/GitHub/Quality-Report/) for details on how these metrics are calculated.

            We are actively working on this report - lots more documentation and extra metrics to come!

            Help us [improve](https://research.typeform.com/to/j06Spdfr?type=quality_report&github_login=sourcery-ai%5Bbot%5D&base_repo=https%3A%2F%2Fgithub.com%2FAstrocyteResearch%2Fs3pypi.git&base_remote_ref=refs%2Fpull%2F1%2Fhead&base_ref=sourcery%2Fmaster&base_sha=054e30337a720e3f320c2d737363c3973cac335f&head_repo=https%3A%2F%2Fgithub.com%2FAstrocyteResearch%2Fs3pypi.git&head_ref=sourcery%2Fsourcery%2Fmaster&base_pr_number=1&base_pr_state=open) this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants