Functions to calculate themal radiation flux #145
+7,784
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 93.94% 93.96% +0.02%
==========================================
Files 10 11 +1
Lines 644 663 +19
==========================================
+ Hits 605 623 +18
- Misses 39 40 +1 ☔ View full report in Codecov by Sentry. |
MasanoriKanamaru
changed the title
hyrodium
reviewed
Aug 13, 2024
test/blackbody_radiation.jl
Outdated
| """ | ||
| println(msg) | ||
|
|
||
| @test AsteroidThermoPhysicalModels.blackbody_radiation(6e-7, 5850) ≈ 2.583616647617974e13 |
There was a problem hiding this comment.
Could you add comments to describe the meanings of the values?
hyrodium
reviewed
Aug 30, 2024
MasanoriKanamaru
force-pushed
the
feature/radiation
branch
from
631271a to
501475f
Compare
Add test for local TPM and thermal radiation calculation
Co-authored-by: Yuto Horikawa <hyrodium@gmail.com>
Add a comment
Co-Authored-By: Yuto Horikawa <hyrodium@gmail.com>
Just add a comment.
`L` denotes radiation [W/m²].
MasanoriKanamaru
force-pushed
the
feature/radiation
branch
from
ce6e404 to
67f61b9
Compare
Just correct some comments.
MasanoriKanamaru
force-pushed
the
feature/radiation
branch
from
0b4cf13 to
89bf365
Compare
Added the value tests of the thermal radiation.
- blackbody_radiation -> blackbody_radiance - thermal_radiation -> thermal_radiance
src/radiation.jl -> src/thermal_radiation.jl
Add a test of blackbody radiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR adds
src/radiation.jlfile to calculate thermal radiation from the simulated temperature distribution. This function does not affect the existing calculations.Updated test files
test/shape/fractal_v2572_f5000.obj: This file is a shape model of a random fractal terrain used in the test attest/blackbody_radiation.jl.test/blackbody_radiation.jl: This file includes tests to check if the new functions don't throw errors and if the output values are valid.Notes
Currently, some tests are incomplete. For example, we have only one shape for the tests. It would be ideal to add more shapes, but we will skip adding them for now.