Skip to content

🐛 Correct invalid plugin reference by marking FFI plugins #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ that can be found in the LICENSE file. -->

# Changelog

## 1.0.0-dev.22

- Correct invalid plugin references by marking FFI plugins.
- Remove duplicate `ios_AgentDart.framework`.

## 1.0.0-dev.21

- Upgrade FRB to 1.82.6.
Expand Down
4 changes: 0 additions & 4 deletions example/linux/flutter/generated_plugin_registrant.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,9 @@

#include "generated_plugin_registrant.h"

#include <agent_dart/agent_dart_plugin.h>
#include <url_launcher_linux/url_launcher_plugin.h>

void fl_register_plugins(FlPluginRegistry* registry) {
g_autoptr(FlPluginRegistrar) agent_dart_registrar =
fl_plugin_registry_get_registrar_for_plugin(registry, "AgentDartPlugin");
agent_dart_plugin_register_with_registrar(agent_dart_registrar);
g_autoptr(FlPluginRegistrar) url_launcher_linux_registrar =
fl_plugin_registry_get_registrar_for_plugin(registry, "UrlLauncherPlugin");
url_launcher_plugin_register_with_registrar(url_launcher_linux_registrar);
Expand Down
2 changes: 1 addition & 1 deletion example/linux/flutter/generated_plugins.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
#

list(APPEND FLUTTER_PLUGIN_LIST
agent_dart
url_launcher_linux
)

list(APPEND FLUTTER_FFI_PLUGIN_LIST
agent_dart
)

set(PLUGIN_BUNDLED_LIBRARIES)
Expand Down
2 changes: 0 additions & 2 deletions example/macos/Flutter/GeneratedPluginRegistrant.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@
import FlutterMacOS
import Foundation

import agent_dart
import url_launcher_macos

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
AgentDartPlugin.register(with: registry.registrar(forPlugin: "AgentDartPlugin"))
UrlLauncherPlugin.register(with: registry.registrar(forPlugin: "UrlLauncherPlugin"))
}
Binary file modified ios/Frameworks/agent_dart-v1.0.0.zip
Binary file not shown.
2 changes: 0 additions & 2 deletions ios/agent_dart.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ Pod::Spec.new do |spec|
spec.source_files = 'Classes/**/*'
spec.public_header_files = 'Classes/**/*.h'
spec.vendored_frameworks = "Frameworks/#{framework_name}"
spec.dependency 'Flutter'

spec.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' }
spec.ios.deployment_target = '11.0'
end
13 changes: 6 additions & 7 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: |
a plugin package for dart and flutter apps.
Developers can build ones to interact with Dfinity's blockchain directly.
repository: https://github.com/AstroxNetwork/agent_dart
version: 1.0.0-dev.21
version: 1.0.0-dev.22

environment:
sdk: '>=3.0.0 <4.0.0'
Expand Down Expand Up @@ -48,16 +48,15 @@ flutter:
plugin:
platforms:
android:
package: com.astrox.agent_dart
pluginClass: AgentDartPlugin
ffiPlugin: true
ios:
pluginClass: AgentDartPlugin
ffiPlugin: true
linux:
pluginClass: AgentDartPlugin
ffiPlugin: true
macos:
pluginClass: AgentDartPlugin
ffiPlugin: true
windows:
pluginClass: AgentDartPlugin
ffiPlugin: true

false_secrets:
- /rust/ed_compact/src/pem.rs
Expand Down