Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Arabic to RTL #547

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Default Arabic to RTL #547

merged 1 commit into from
Sep 17, 2020

Conversation

ebetica
Copy link
Collaborator

@ebetica ebetica commented Sep 15, 2020 •
edited
Loading

Tackles #486 by defaulting all arabic text to RTL on the sidebar and main page:

image

@ebetica ebetica mentioned this pull request Sep 15, 2020
Open
@ebetica ebetica requested a review from Atcold September 15, 2020 16:52
Atcold
Atcold approved these changes Sep 17, 2020
View reviewed changes
Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supposed to change something for the Arabic MD files, or you're handling this internally?
We're starting with Farsi soon as well, so that will also need a similar layout.

@Atcold Atcold merged commit d690699 into Atcold:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atcold Atcold Atcold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebetica @Atcold