-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 12-3.md #780
Update 12-3.md #780
Conversation
Self-Attention Paragraph Typos: Issues Atcold#779
Correction in Spanish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations will have 2 typos, in the English comment and in the translated text.
Please, fix both, so that there are no discrepancies.
Thanks!
@@ -49,7 +49,7 @@ $$ | |||
\boldsymbol{h} = \boldsymbol{X} \boldsymbol{a} | |||
$$ | |||
|
|||
where $\boldsymbol{a} \in \mathbb{R}^n$ is a column vector with components $\alpha_i$. | |||
where $\boldsymbol{a} \in \mathbb{R}^t$ is a column vector with components $\alpha_i$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the comment (which you correctly fixed), but you forgot to edit line 81 below.
docs/ja/week12/12-3.md
Outdated
@@ -47,7 +47,7 @@ $$ | |||
$$ | |||
|
|||
<!-- where $\boldsymbol{a} \in \mathbb{R}^n$ is a column vector with components $\alpha_i$. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- where $\boldsymbol{a} \in \mathbb{R}^n$ is a column vector with components $\alpha_i$. --> | |
<!-- where $\boldsymbol{a} \in \mathbb{R}^t$ is a column vector with components $\alpha_i$. --> |
Co-authored-by: Alfredo Canziani <alfredo.canziani@gmail.com>
Thanks @Atcold! Now everything should be fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks so much!
Self-Attention Paragraph Typos: Issues #779