fix certreloader update logic #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4niwa
force-pushed
the
fix-certreloader-update
branch
from
627d67b to
27d95e8
Compare
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
t4niwa
force-pushed
the
fix-certreloader-update
branch
from
27d95e8 to
0b89c12
Compare
mlajkim
reviewed
Mar 26, 2024
mlajkim
reviewed
Mar 26, 2024
if config.ProviderService == "" && config.CertFile != "" && config.KeyFile != "" {
go r.pollRefresh()
} |
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
mlajkim
previously approved these changes
Mar 27, 2024
WindzCUHK
reviewed
Mar 27, 2024
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
t4niwa
force-pushed
the
fix-certreloader-update
branch
from
4233af8 to
7a8d1f2
Compare
WindzCUHK
reviewed
Mar 27, 2024
…fix-certreloader-update
t4niwa
force-pushed
the
fix-certreloader-update
branch
from
5ce8380 to
270c3fb
Compare
mlajkim
reviewed
Mar 28, 2024
t4niwa
force-pushed
the
fix-certreloader-update
branch
from
99c1812 to
8adeac9
Compare
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
t4niwa
force-pushed
the
fix-certreloader-update
branch
from
8adeac9 to
a50f2ab
Compare
WindzCUHK
approved these changes
Mar 29, 2024
2 tasks
y-myajima
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix certreloader update Signed-off-by: taniwa <taniwa@lycorp.co.jp> * update tls-reload Signed-off-by: taniwa <taniwa@lycorp.co.jp> * log: small (#112) * revert update cert reloader logic Signed-off-by: taniwa <taniwa@lycorp.co.jp> * rollback tls-reload Signed-off-by: taniwa <taniwa@lycorp.co.jp> --------- Signed-off-by: taniwa <taniwa@lycorp.co.jp> Co-authored-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com> Signed-off-by: myajima <myajima@lycorp.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
panic occurred because cert reloader attempted to update even though certificate retrieval failed
This PR adds the red box in the following diagram:
Type of change
Flags
Related issue/PR
Delete this section if there are no issues or pull requests that relate to this pull request.
Checklist
[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]in the PR title if necessaryChecklist for maintainer
Squash and merge[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]