Exclude from certificate monitoring if SIA's Certificate File or Ca Cert File Path is Empty #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: myajima <myajima@lycorp.co.jp>
y-myajima
force-pushed
the
exclude-from-cert-monitoring
branch
from
0e0bfc2 to
88baa4b
Compare
y-myajima
added
bug
mlajkim
reviewed
Nov 19, 2024
Signed-off-by: myajima <myajima@lycorp.co.jp>
mlajkim
reviewed
Dec 2, 2024
There was a problem hiding this comment.
- Consider the following:
I don't want to make changes in this PR here, but I found out that the current logic where exporter not being able to watch the service-cert or ca-cert just because it couldn't get the rolecert path is a bit over the top. prolly requires a new issue.
mlajkim
reviewed
Dec 2, 2024
There was a problem hiding this comment.
- Consider the following:
I think the following change is enough for this PR: main...suggestion/exclude-from-cert-monitoring-jekim
|
Signed-off-by: myajima <myajima@lycorp.co.jp>
|
Created an issue: |
WindzCUHK
pushed a commit
that referenced
this pull request
Dec 3, 2024
…ert File Path is Empty (#171) * exclude from cert monitoring Signed-off-by: myajima <myajima@lycorp.co.jp> * use anonymous func Signed-off-by: myajima <myajima@lycorp.co.jp> * only service cert Signed-off-by: myajima <myajima@lycorp.co.jp> --------- Signed-off-by: myajima <myajima@lycorp.co.jp> Signed-off-by: wfan <wfan@lycorp.co.jp>
WindzCUHK
added a commit
that referenced
this pull request
Dec 3, 2024
…own (#173) * use config variable Signed-off-by: wfan <wfan@lycorp.co.jp> * add forceful shutdown logic Signed-off-by: wfan <wfan@lycorp.co.jp> * fix all shutdown Signed-off-by: wfan <wfan@lycorp.co.jp> * add comment Signed-off-by: wfan <wfan@lycorp.co.jp> * (revert later) confirm race resolved Signed-off-by: wfan <wfan@lycorp.co.jp> * Exclude from certificate monitoring if SIA's Certificate File or Ca Cert File Path is Empty (#171) * exclude from cert monitoring Signed-off-by: myajima <myajima@lycorp.co.jp> * use anonymous func Signed-off-by: myajima <myajima@lycorp.co.jp> * only service cert Signed-off-by: myajima <myajima@lycorp.co.jp> --------- Signed-off-by: myajima <myajima@lycorp.co.jp> Signed-off-by: wfan <wfan@lycorp.co.jp> * Revert "(revert later) confirm race resolved" This reverts commit 2e8bfe6. Signed-off-by: wfan <wfan@lycorp.co.jp> --------- Signed-off-by: wfan <wfan@lycorp.co.jp> Signed-off-by: myajima <myajima@lycorp.co.jp> Co-authored-by: y-myajima <137997379+y-myajima@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where a warning log from the x509-certificate-exporter was unnecessarily output when CA_CERT_FILE was empty at startup.
#134
Assignees
Assigneesis setType of changes
labelsof the following that fits:bug: Bug fixdependencies: Dependency upgradesdocumentation: Documentation changesenhancement: New Featuregood first issue: First contributionlogging: Log changesrefactor: Refactoring (no functional changes, no api changes)Flags
Checklist
Checklist for maintainer