Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue1724 #3365

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Feature/issue1724 #3365

merged 3 commits into from
Nov 4, 2024

Conversation

temi
Copy link
Contributor

@temi temi commented Nov 1, 2024

No description provided.

temi added 2 commits November 1, 2024 16:41
@temi
#1724
1db8e08 
- added statewide property
- added behaviour changes based on national and statewide selection
- electorate selection automatically adds its states
@temi
#1724
c638b4e 
- added text for national project
@temi temi requested a review from chrisala November 1, 2024 05:55
chrisala
chrisala reviewed Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@chrisala chrisala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test so I haven't merged.

@temi
#1724
8270675 
- fixes a test fail
@temi
Copy link
Contributor Author

temi commented Nov 4, 2024

@chrisala this is now fixed.

@chrisala chrisala merged commit 7123596 into dev Nov 4, 2024
1 check passed
@chrisala chrisala deleted the feature/issue1724 branch December 16, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisala chrisala chrisala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@temi @chrisala