Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for references to color values in Dart #169

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

Lootwig
Copy link
Contributor

@Lootwig Lootwig commented Sep 5, 2024

Variables that reference a Color are included in highlighting, independent of their name

Motivation and Context

I need to see the colors where I use them, with current version they only show at the declaration, which is in a central theme definition

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-Functional Change (non-user facing changes)

Checklist:

  • My code follows the code style of this project (./gradlew check passes clean).
    • Tons of warnings from code I didn't touch
  • I updated the version.
  • [ x I updated the changelog with the new functionality.

@Lootwig Lootwig marked this pull request as ready for review September 5, 2024 13:51
@Lootwig
Copy link
Contributor Author

Lootwig commented Sep 9, 2024

@mallowigi while this isn't merged yet (need something from me?), I wanted to add another edge case I discovered - however, I think I'm wasting quite a bit of time on this because I haven't figured out how to run the tests/debug without firing up that heavy test IDE each time - any hints on this?

@mallowigi
Copy link
Collaborator

mallowigi commented Sep 9, 2024

I wanted to release a new version but I got sidelined a bit. I'll see if I can find the time to check the state.

And yes, this needs to run a sandbox version of the IDE. There's a way to run it headless but tbh I didn't really invest times into the tests.

@mallowigi mallowigi merged commit 0ada0f7 into AtomMaterialUI:master Sep 13, 2024
1 check failed
mallowigi added a commit that referenced this pull request Sep 13, 2024
Support for references to color values in Dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants