fix the native blake2 bindings issue#14
Open
kamalbuilds wants to merge 2 commits intoAtomaAI:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request replaces the native Node.js C++ BLAKE2 bindings with a pure JavaScript implementation using the @noble/hashes library to improve portability and remove native dependencies.
- Removed the native blake2 import and usage.
- Added the @noble/hashes/blake2b implementation with the appropriate digest length configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
The issue is that the sdk is trying to use the native blake2 Node.js module which requires C++ bindings, but those bindings aren't available.
However, there are pure JavaScript/TypeScript implementations of BLAKE2 that we can use instead and in this PR uses it.
The advantages of this approach are:
The @noble/hashes library is a popular choice for cryptographic hashes in JavaScript/TypeScript projects and provides a more portable solution than the native blake2 module. It implements the same BLAKE2b algorithm, so the cryptographic properties and output will be identical to the native version.