Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Fixes #12

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Minor Fixes #12

merged 3 commits into from
Oct 1, 2023

Conversation

misalazeem
Copy link
Collaborator

  • Fixed some console warnings appearing due to prop definitions.
  • Fixed some console warnings appearing due to default value / value of select boxes.

andrianarivo
andrianarivo approved these changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@andrianarivo andrianarivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @misalazeem ,

Your changes look good to me. Its time to merge it 🥳 🥳 🥳

Highlights:

  • No linter Errors
  • Descriptive PR

GOod luck and happy coding.
Contact me if you have any questions.

@misalazeem misalazeem merged commit f4b925a into dev Oct 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrianarivo andrianarivo andrianarivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misalazeem @andrianarivo