refactor: using methods from the standard library #10829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linchizhen
force-pushed
the
main
branch
2 times, most recently
from
6513970 to
aa68185
Compare
alecsavvy
approved these changes
Jan 3, 2025
Thanks for your review. It is my pleasure. |
Signed-off-by: linchizhen <jiayanbing@yeah.net>
I have resolved the conflict, please review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because there are already relevant methods in the standard library that can be directly used
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.