More flexible #14
Merged
More flexible #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved FileHandlerTest and SecurityTest from Unit to Integration folder to resolve database dependency issues. Integration tests are expected to require database connections, which are available both locally and on GitHub CI (MySQL/PostgreSQL containers). Changes: - tests/Unit/FileHandlerTest.php → tests/Integration/FileHandlerTest.php - tests/Unit/SecurityTest.php → tests/Integration/SecurityTest.php - Removed DB/Schema facade mocking (no longer needed) - Kept Storage::fake() for filesystem testing Tests will now work in both environments: - Locally: with running MySQL/PostgreSQL - GitHub CI: with service containers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed multiple test issues that appeared after moving unit tests: 1. FlexyFieldTypeEnumTest: Updated enum count from 7 to 8 (added FILE type) 2. FileFieldTest: - Fixed test model to implement FlexyModelContract interface - Fixed SchemaField type comparison (enum vs string) 3. FileHandlerTest: - Fixed path traversal test (sanitizes instead of throwing) - Fixed signed URL test (checks for expiration param) - Fixed invalid upload test (removed broken reflection approach) 4. SecurityTest: - Fixed path traversal test behavior expectations - Fixed metadata override test (use .zip instead of .txt) - Simplified logging test All newly moved integration tests now pass: - FileHandlerTest: 24/24 ✅ - SecurityTest: 20/20 ✅ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed multiple critical issues with file field implementation: 1. **Flexy Trait Fixes**: - Changed handleFileUpload visibility from private to protected - Fixed $this context issue in static::saving callback - Added Illuminate\Support\Str import - Update in-memory flexy field after file upload - Fixed deleteFlexyFile SchemaField query (use whereHas) - Update in-memory field to null after file deletion 2. **Test Database Setup**: - FileFieldTest: Added database table creation (MySQL/PostgreSQL/SQLite) - FileFieldIntegrationTest: Fixed table name (ff_example_flexy_models) - Fixed SQL syntax for different database drivers 3. **Test Fixes**: - Fixed ExampleFlexyModel import namespace - Fixed signed URL test expectations - Fixed null file field validation test (update to nullable) - Fixed SchemaField relation name (fieldSchema -> schema) All tests now passing: - 346 passed - 3 skipped - 852 assertions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.