Use steady_clock to measure connection timeout #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection timeout in the connection class was using the
std::chrono::system_clockwhich is not monotonic and susceptible to time jumps when system wall clock is adjusted, see here: https://en.cppreference.com/w/cpp/chrono/system_clockThis can lead to connection timeout incorrectly evaluated.
std::chrono::steady_clockshould be used instead, as it is not susceptible for wall clock adjustments and should be preferred for time duration measurements: https://en.cppreference.com/w/cpp/chrono/steady_clockThe PR changes are the following:
millis()public method from utilsstd::chrono::millisecondsfor a more explicit typesteady_clockto sample timestamps to measure connection timeout