Skip to content

Dev#23

Merged
Hojip-Kim merged 3 commits intomainfrom
dev
Nov 11, 2025
Merged

Dev#23
Hojip-Kim merged 3 commits intomainfrom
dev

Conversation

@parkji1on
Copy link
Contributor

요약

  • 이 PR의 목적과 배경을 한 줄로 설명해주세요.

주요 변경 사항

  • 변경 요약 1
  • 변경 요약 2

관련 이슈

  • Closes #번호 (예: Closes #123)

테스트/검증

  • 어떻게 검증했는지, 영향 범위는 어디인지 간략히 적어주세요.

확인 사항

  • 자기 리뷰 완료
  • 빌드/테스트 통과 확인
  • 문서/주석 업데이트(필요 시)
  • 브레이킹 체인지 없음 또는 마이그레이션 안내 포함

스크린샷/로그(선택)

  • 필요 시 첨부

@github-actions
Copy link

PR 검증 성공

브랜치: devmain
커밋: 7d78667

모든 검증을 통과했습니다. 리뷰를 요청해주세요.

워크플로우 로그 확인

Copy link
Contributor

@Hojip-Kim Hojip-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hojip-Kim Hojip-Kim merged commit 516c42b into main Nov 11, 2025
9 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes API response formats in the DeviceTokenController by introducing a consistent ApiResponse<T> wrapper for all endpoints. The changes replace ad-hoc response structures (like HashMap) with a unified response format that includes status, success flag, message, and data fields.

Key Changes:

  • Replaced manual HashMap response construction with ApiResponse wrapper in the register endpoint
  • Standardized all endpoint return types to use ResponseEntity<ApiResponse<T>> pattern
  • Added consistent success messages for all operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants