Dev by parkji1on · Pull Request #60 · AutoEver-4Ever/_4EVER_BE_SCM

parkji1on · 2025-11-11T10:26:57Z

요약

이 PR의 목적과 배경을 한 줄로 설명해주세요.

주요 변경 사항

변경 요약 1
변경 요약 2

테스트/검증

어떻게 검증했는지, 영향 범위는 어디인지 간략히 적어주세요.

확인 사항

자기 리뷰 완료
빌드/테스트 통과 확인
문서/주석 업데이트(필요 시)
브레이킹 체인지 없음 또는 마이그레이션 안내 포함

스크린샷/로그(선택)

필요 시 첨부

[Feat] ALARM 연동

github-actions · 2025-11-11T10:27:50Z

✅ PR 검증 성공

브랜치: dev → main
커밋: 2c692c0

모든 검증을 통과했습니다. 리뷰를 요청해주세요.

워크플로우 로그 확인

DonjJin-github

고생하셨습니다

Copilot

Pull Request Overview

This PR introduces an alarm/notification system to the SCM service. The changes add event-driven notification functionality using Kafka to send alerts to users when specific purchase-related actions occur (requisition approval/rejection, purchase order approval/rejection/delivery).

Added alarm event data models including AlarmEvent, AlarmSentEvent, StatusEvent, and supporting enum types
Integrated alarm notification sending at key business events in purchase requisition and purchase order workflows
Updated Kafka infrastructure to support new alarm topics and event handling

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
TargetType.java	New enum defining alarm recipient types (employee, department, customer, supplier)
SourceType.java	New enum defining alarm source systems with conversion and validation utilities
LinkType.java	New enum defining types of linked documents for alarm references
AlarmType.java	New enum defining alarm categories by department/module
StatusEvent.java	New event class for tracking alarm processing status with failure details
AlarmSentEvent.java	New event class for alarm delivery notifications from alarm server to clients
AlarmEvent.java	New event class for alarm requests from services to alarm server
QuotationServiceImpl.java	Added TODO comment for quotation confirmation alarm
MesServiceImpl.java	Added empty line (whitespace change)
PurchaseRequisitionServiceImpl.java	Integrated alarm sending for requisition approval and rejection
PurchaseOrderServiceImpl.java	Integrated alarm sending for order approval, rejection, delivery start, and delivery completion
SalesOrderServiceImpl.java	Added TODO comment for sales order shipment completion alarm
KafkaProducerServiceImpl.java	Updated to use new alarm topic and improved code formatting
KafkaProducerService.java	Updated import structure and formatting
AlarmStatusEventListener.java	New Kafka listener for handling alarm status events
KafkaTopicConfig.java	Added new alarm-related Kafka topics
.husky/pre-commit	Removed husky pre-commit hook
.husky/commit-msg	Removed husky commit message hook

Comments suppressed due to low confidence (1)

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseOrderServiceImpl.java:1

Duplicate UUID generation on lines 512 and 516. Both eventId and alarmId are being assigned the same UUID value, but calling UuidCreator.getTimeOrderedEpoch().toString() twice may generate different values. If they should be the same, generate once and reuse; if different, this is likely unintended.

package org.ever._4ever_be_scm.scm.mm.service.impl;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T10:32:31Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseRequisitionServiceImpl.java

+        AlarmEvent alarmEventForCreate = AlarmEvent.builder()
+            .eventId(UuidCreator.getTimeOrderedEpoch().toString())
+            .eventType(AlarmEvent.class.getName())
+            .timestamp(LocalDateTime.now())
+            .source(SourceType.SCM.name())
+            .alarmId(UuidCreator.getTimeOrderedEpoch().toString())


Duplicate UUID generation on lines 323 and 327. Both eventId and alarmId are being assigned the same UUID value, but calling UuidCreator.getTimeOrderedEpoch().toString() twice may generate different values. If they should be the same, generate once and reuse; if different, this is likely unintended. This pattern repeats throughout the file.

Suggested change

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(UuidCreator.getTimeOrderedEpoch().toString())

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(UuidCreator.getTimeOrderedEpoch().toString())

String uuid = UuidCreator.getTimeOrderedEpoch().toString();

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(uuid)

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(uuid)

Copilot · 2025-11-11T10:32:32Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseRequisitionServiceImpl.java

+        AlarmEvent alarmEventForCreate = AlarmEvent.builder()
+            .eventId(UuidCreator.getTimeOrderedEpoch().toString())
+            .eventType(AlarmEvent.class.getName())
+            .timestamp(LocalDateTime.now())
+            .source(SourceType.SCM.name())
+            .alarmId(UuidCreator.getTimeOrderedEpoch().toString())


Duplicate UUID generation on lines 386 and 390. Both eventId and alarmId are being assigned the same UUID value, but calling UuidCreator.getTimeOrderedEpoch().toString() twice may generate different values. If they should be the same, generate once and reuse; if different, this is likely unintended.

Suggested change

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(UuidCreator.getTimeOrderedEpoch().toString())

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(UuidCreator.getTimeOrderedEpoch().toString())

String alarmEventId = UuidCreator.getTimeOrderedEpoch().toString();

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(alarmEventId)

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(alarmEventId)

Copilot · 2025-11-11T10:32:33Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseOrderServiceImpl.java

+            AlarmEvent alarmEventForCreate = AlarmEvent.builder()
+                .eventId(UuidCreator.getTimeOrderedEpoch().toString())
+                .eventType(AlarmEvent.class.getName())
+                .timestamp(LocalDateTime.now())
+                .source(SourceType.SCM.name())
+                .alarmId(UuidCreator.getTimeOrderedEpoch().toString())


Duplicate UUID generation on lines 395 and 399. Both eventId and alarmId are being assigned the same UUID value, but calling UuidCreator.getTimeOrderedEpoch().toString() twice may generate different values. If they should be the same, generate once and reuse; if different, this is likely unintended. This pattern repeats in multiple places in this file.

Suggested change

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(UuidCreator.getTimeOrderedEpoch().toString())

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(UuidCreator.getTimeOrderedEpoch().toString())

String eventAlarmUuid = UuidCreator.getTimeOrderedEpoch().toString();

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(eventAlarmUuid)

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(eventAlarmUuid)

Copilot · 2025-11-11T10:32:33Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseOrderServiceImpl.java

+                .targetType(TargetType.EMPLOYEE)
+                .title("발주서 승인")
+                .message("해당 발주서가 승인되었습니다. 발주서 번호 = " + productOrder.getProductOrderCode())
+                .linkId(productOrder.getProductOrderCode())


Inconsistent linkId field usage. Line 405 uses productOrder.getProductOrderCode() while other alarm events in this file (lines 523, 590, 710) also use the same. However, in PurchaseRequisitionServiceImpl, the linkId is set to productRequest.getId() (lines 333, 396). The linkId should consistently use either the ID or the code, not mix both approaches.

Suggested change

.linkId(productOrder.getProductOrderCode())

.linkId(productOrder.getId())

Copilot · 2025-11-11T10:32:34Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseOrderServiceImpl.java

+        AlarmEvent alarmEventForCreate = AlarmEvent.builder()
+            .eventId(UuidCreator.getTimeOrderedEpoch().toString())
+            .eventType(AlarmEvent.class.getName())
+            .timestamp(LocalDateTime.now())
+            .source(SourceType.SCM.name())
+            .alarmId(UuidCreator.getTimeOrderedEpoch().toString())


Duplicate UUID generation on lines 580 and 584. Both eventId and alarmId are being assigned the same UUID value, but calling UuidCreator.getTimeOrderedEpoch().toString() twice may generate different values. If they should be the same, generate once and reuse; if different, this is likely unintended.

Suggested change

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(UuidCreator.getTimeOrderedEpoch().toString())

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(UuidCreator.getTimeOrderedEpoch().toString())

String alarmEventId = UuidCreator.getTimeOrderedEpoch().toString();

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(alarmEventId)

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(alarmEventId)

Copilot · 2025-11-11T10:32:34Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseOrderServiceImpl.java

+        AlarmEvent alarmEventForCreate = AlarmEvent.builder()
+            .eventId(UuidCreator.getTimeOrderedEpoch().toString())
+            .eventType(AlarmEvent.class.getName())
+            .timestamp(LocalDateTime.now())
+            .source(SourceType.SCM.name())
+            .alarmId(UuidCreator.getTimeOrderedEpoch().toString())


Duplicate UUID generation on lines 700 and 704. Both eventId and alarmId are being assigned the same UUID value, but calling UuidCreator.getTimeOrderedEpoch().toString() twice may generate different values. If they should be the same, generate once and reuse; if different, this is likely unintended.

Suggested change

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(UuidCreator.getTimeOrderedEpoch().toString())

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(UuidCreator.getTimeOrderedEpoch().toString())

String alarmEventId = UuidCreator.getTimeOrderedEpoch().toString();

AlarmEvent alarmEventForCreate = AlarmEvent.builder()

.eventId(alarmEventId)

.eventType(AlarmEvent.class.getName())

.timestamp(LocalDateTime.now())

.source(SourceType.SCM.name())

.alarmId(alarmEventId)

Copilot · 2025-11-11T10:32:34Z

src/main/java/org/ever/_4ever_be_scm/scm/mm/service/impl/PurchaseRequisitionServiceImpl.java

+        kafkaProducerService.sendAlarmEvent(alarmEventForCreate)
+            .whenComplete((result, ex) -> {
+                if (ex != null) {
+                    log.error("[ALARM] 알림 요청 전송 실패 - alarmId: {}, targetId: {}, error: {}",
+                        alarmEventForCreate.getAlarmId(), targetId, ex.getMessage(), ex);
+                } else if (result != null) {
+                    log.info("[ALARM] 알림 요청 전송 성공 - topic: {}, partition: {}, offset: {}",
+                        result.getRecordMetadata().topic(),
+                        result.getRecordMetadata().partition(),
+                        result.getRecordMetadata().offset());
+                } else {
+                    log.warn("[ALARM] 알림 요청 전송 결과가 null 입니다 - alarmId: {}, targetId: {}",
+                        alarmEventForCreate.getAlarmId(), targetId);
+                }
+            });


Duplicated alarm event logging code. This exact logging pattern for handling alarm event results is repeated multiple times across PurchaseRequisitionServiceImpl and PurchaseOrderServiceImpl. Consider extracting this into a reusable method or utility to reduce code duplication and improve maintainability.

Copilot · 2025-11-11T10:32:35Z

src/main/java/org/ever/_4ever_be_scm/infrastructure/kafka/config/KafkaTopicConfig.java

+//    public static final String ALARM_SENT_TOPIC = "alarm-sent"; // 알림 발송
+//    public static final String ALARM_SENT_STATUS_TOPIC = "alarm-sent-status"; // 알림 발송 상태
+
    @Bean


Missing Kafka topic bean definitions. While ALARM_REQUEST_TOPIC and ALARM_REQUEST_STATUS_TOPIC constants are defined, there are no corresponding @Bean methods to actually create these topics (unlike other topics in this file which have bean definitions). This will cause the topics not to be auto-created by Spring Kafka.

Suggested change

@Bean

@Bean

public NewTopic alarmRequestTopic() {

return TopicBuilder.name(ALARM_REQUEST_TOPIC)

.partitions(3)

.replicas(1)

.build();

}

@Bean

public NewTopic alarmRequestStatusTopic() {

return TopicBuilder.name(ALARM_REQUEST_STATUS_TOPIC)

.partitions(3)

.replicas(1)

.build();

}

@Bean

Copilot · 2025-11-11T10:32:35Z

src/main/java/org/ever/event/alarm/SourceType.java

+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+
+@Getter
+@RequiredArgsConstructor


Unnecessary Lombok annotations on enum. The @RequiredArgsConstructor annotation is unnecessary for enums as they cannot have constructors in the traditional sense. Additionally, @Getter is redundant since enum values are already accessible. These annotations have no effect and should be removed.

Suggested change

import lombok.Getter;

import lombok.RequiredArgsConstructor;

@Getter

@RequiredArgsConstructor

Copilot · 2025-11-11T10:32:35Z

src/main/java/org/ever/event/StatusEvent.java

+import org.ever._4ever_be_scm.infrastructure.kafka.event.BaseEvent;
+
+@Getter
+@SuperBuilder


Default toString(): FailureInfo inherits toString() from Object, and so is not suitable for printing.

DonjJin-github and others added 14 commits November 11, 2025 14:27

refac(scm): 알람필요 주석

8adbf7f

refac(scm): 알람필요 주석 수정

d1731b8

refac(scm): 알람필요 주석 수정

ab68645

feat(alarm): Alarm과 관련된 Event 정의 (#58)

f385bd9

feat(kafka): 알림 전송 요청 Kafka Producer 생성 (#58)

6323c63

feat(kafka): ALARM 에 보낸 Event에 대한 결과 Listener (#58)

783714d

feat(kafka): ALARM과 관련한 Topic 생성 (#58)

ce8face

Merge branch 'main' of github.com:/AutoEver-4Ever/_4EVER_BE_SCM into dev

ebe2c3e

feat(alarm): 구매 요청서 관련 알림 생성 (#58)

4a8b90b

feat(alarm): 발주서에 대한 알림 생성 (#58)

e022649

comment(): 알림 완료 (#58)

fa5d185

Merge branch 'dev' into feat/#58-alarm

1511b3e

feat(): import 문 추가 (#58)

9fe54e1

Merge pull request #59 from AutoEver-4Ever/feat/#58-alarm

2c692c0

[Feat] ALARM 연동

parkji1on requested review from DonjJin-github and Copilot November 11, 2025 10:26

Copilot started reviewing on behalf of parkji1on November 11, 2025 10:27 View session

Copilot finished reviewing on behalf of parkji1on November 11, 2025 10:29

DonjJin-github approved these changes Nov 11, 2025

View reviewed changes

DonjJin-github merged commit aeb1a05 into main Nov 11, 2025
11 checks passed

Copilot AI reviewed Nov 11, 2025

View reviewed changes

	.linkId(productOrder.getProductOrderCode())
	.linkId(productOrder.getId())

-    @Bean
+    @Bean
+    public NewTopic alarmRequestTopic() {
+        return TopicBuilder.name(ALARM_REQUEST_TOPIC)
+            .partitions(3)
+            .replicas(1)
+            .build();
+    }
+    @Bean
+    public NewTopic alarmRequestStatusTopic() {
+        return TopicBuilder.name(ALARM_REQUEST_STATUS_TOPIC)
+            .partitions(3)
+            .replicas(1)
+            .build();
+    }
+    @Bean

Conversation

parkji1on commented Nov 11, 2025

요약

주요 변경 사항

관련 이슈

테스트/검증

확인 사항

스크린샷/로그(선택)

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

DonjJin-github left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants