Conversation
feat(alarm): Alarm Type 변경
|
✅ PR 검증 성공 브랜치: 모든 검증을 통과했습니다. 리뷰를 요청해주세요. |
There was a problem hiding this comment.
Pull Request Overview
This PR changes the alarm type for purchase order notifications from AlarmType.PR (Purchase Request - 구매부) to AlarmType.SD (Sales Document - 영업부) across four different alarm scenarios in the PurchaseOrderServiceImpl service.
Key Changes
- Modified alarm type from
PRtoSDfor purchase order approval notifications - Modified alarm type from
PRtoSDfor purchase order rejection notifications - Modified alarm type from
PRtoSDfor delivery start notifications - Modified alarm type from
PRtoSDfor delivery completion notifications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .source(SourceType.SCM.name()) | ||
| .alarmId(UuidCreator.getTimeOrderedEpoch().toString()) | ||
| .alarmType(AlarmType.PR) | ||
| .alarmType(AlarmType.SD) |
There was a problem hiding this comment.
The change from AlarmType.PR to AlarmType.SD is incorrect. Purchase Orders belong to the procurement department (구매부) and should use AlarmType.PR, not AlarmType.SD which is for sales operations (영업부). This inconsistency affects the alarm categorization system.
| .alarmType(AlarmType.SD) | |
| .alarmType(AlarmType.PR) |
| .source(SourceType.SCM.name()) | ||
| .alarmId(UuidCreator.getTimeOrderedEpoch().toString()) | ||
| .alarmType(AlarmType.PR) | ||
| .alarmType(AlarmType.SD) |
There was a problem hiding this comment.
The change from AlarmType.PR to AlarmType.SD is incorrect. Purchase Orders belong to the procurement department (구매부) and should use AlarmType.PR, not AlarmType.SD which is for sales operations (영업부). This inconsistency affects the alarm categorization system.
| .alarmType(AlarmType.SD) | |
| .alarmType(AlarmType.PR) |
| .source(SourceType.SCM.name()) | ||
| .alarmId(UuidCreator.getTimeOrderedEpoch().toString()) | ||
| .alarmType(AlarmType.PR) | ||
| .alarmType(AlarmType.SD) |
There was a problem hiding this comment.
The change from AlarmType.PR to AlarmType.SD is incorrect. Purchase Orders belong to the procurement department (구매부) and should use AlarmType.PR, not AlarmType.SD which is for sales operations (영업부). This inconsistency affects the alarm categorization system.
| .alarmType(AlarmType.SD) | |
| .alarmType(AlarmType.PR) |
| .source(SourceType.SCM.name()) | ||
| .alarmId(UuidCreator.getTimeOrderedEpoch().toString()) | ||
| .alarmType(AlarmType.PR) | ||
| .alarmType(AlarmType.SD) |
There was a problem hiding this comment.
The change from AlarmType.PR to AlarmType.SD appears to be incorrect. Based on the enum definitions:
AlarmType.PR= Purchase Request (구매부)AlarmType.SD= Sales Document (영업부)
The LinkType enum clearly categorizes PURCHASE_ORDER under the PR (구매부) section, not SD (영업부). Additionally, the related PurchaseRequisitionServiceImpl correctly uses AlarmType.PR for purchase requisitions.
Since this service handles Purchase Orders (발주서), which are procurement/purchasing operations (구매부), the alarm type should be AlarmType.PR, not AlarmType.SD. Sales Document (SD) is intended for sales operations (영업부) like quotations and sales orders.
Consider reverting this change to use AlarmType.PR.
| .alarmType(AlarmType.SD) | |
| .alarmType(AlarmType.PR) |
요약
주요 변경 사항
관련 이슈
테스트/검증
확인 사항
스크린샷/로그(선택)