feat(connect): add log and metrics support for connect #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshigaopp
requested review from
superhx,
Gezi-lzq and
1sonofqiu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the new AutoMQ Log Uploader module, which provides asynchronous S3 log upload capabilities for Log4j 1.x. The changes include module setup, configuration documentation, and core implementation files that enable log events to be buffered, compressed, and uploaded to object storage, with support for flexible leader election and configuration strategies.
Module setup and documentation:
automq-log-uploader/README.mdwith detailed instructions on integration, configuration options, and leader election strategies for S3 log uploading, making it easier for other modules to adopt and configure the uploader.automq-log-uploader/build.gradleto define dependencies and build configuration for the new module, ensuring proper integration with required libraries and submodules.Core implementation and configuration:
LogConfigConstantsclass to centralize all configuration keys, defaults, and documentation for log uploader settings.DefaultS3LogConfigclass to load, normalize, and provide log uploader configuration, including S3 bucket setup, credentials, and dynamic leader election strategy instantiation.LogRecorderinterface and its nestedLogEventclass for capturing and validating log events to be uploaded, forming the basis for log event handling in the uploader.