Refactor/monorepo restructure #37
Conversation
Summary of ChangesHello @webdevcody, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project by migrating it to a monorepo architecture. The primary goal is to centralize code management for different applications, such as the main app and the marketing site, under a single repository. This change involves extensive file renames and updates to package configurations to support the new workspace setup, aiming to streamline development and dependency management across related projects. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@copilot summery this PR in depth |
|
@GTheMachine I've opened a new pull request, #38, to work on those changes. Once the pull request is ready, I'll request review from you. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the project into a monorepo structure, separating the main application and the marketing site into their own workspaces under an apps directory. This is a good structural improvement for managing different parts of the project. My review focuses on the new configuration files introduced for the monorepo setup. I've identified a couple of areas for improvement in the root package.json and .gitignore to make the monorepo setup more robust and maintainable.
| dist/ | ||
| .next/ |
There was a problem hiding this comment.
To make the root .gitignore more comprehensive for a monorepo, consider adding other common build output directories that are present in workspace .gitignore files, such as out/ and build/. This helps centralize ignore patterns and ensures future workspaces are covered.
dist/
.next/
out/
build/
| "dev": "npm run dev --workspace=apps/app", | ||
| "dev:web": "npm run dev:web --workspace=apps/app", | ||
| "dev:electron": "npm run dev:electron --workspace=apps/app", | ||
| "dev:electron:wsl": "npm run dev:electron:wsl --workspace=apps/app", | ||
| "dev:electron:wsl:gpu": "npm run dev:electron:wsl:gpu --workspace=apps/app", | ||
| "build": "npm run build --workspace=apps/app", | ||
| "build:electron": "npm run build:electron --workspace=apps/app", | ||
| "start": "npm run start --workspace=apps/app", | ||
| "lint": "npm run lint --workspace=apps/app", | ||
| "test": "npm run test --workspace=apps/app", | ||
| "test:headed": "npm run test:headed --workspace=apps/app", | ||
| "dev:marketing": "npm run dev --workspace=apps/marketing" |
There was a problem hiding this comment.
The scripts are hardcoded to use npm run ... --workspace=..., which is specific to npm v7+. Given that the .gitignore files contain entries for yarn and pnpm, this might cause issues for developers using those package managers. Consider using a more package-manager-agnostic approach, or ensuring the team standardizes on npm.
There was a problem hiding this comment.
and what are package-manager-agnostic approaches
There was a problem hiding this comment.
Pull request overview
This PR implements a major monorepo restructure for the Automaker project, organizing code into separate workspace packages for the main application and marketing site. The changes establish a clean workspace structure with proper separation of concerns.
Key Changes:
- Monorepo workspace configuration with apps for main application and marketing site
- Marketing landing page with Dockerfile for containerized deployment
- Comprehensive test utilities for Playwright end-to-end testing
- Type definitions for Electron IPC, sessions, and auto-mode events
- State management stores for app and setup workflows
- Utility libraries for project initialization, logging, and agent context parsing
- Custom React hooks for window state, scrolling, message queuing, keyboard shortcuts, and auto-mode management
Reviewed changes
Copilot reviewed 4 out of 163 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Root workspace configuration defining apps and libs workspaces |
| apps/marketing/public/index.html | Static marketing landing page with feature showcase |
| apps/marketing/package.json | Marketing app package using serve for local development |
| apps/marketing/Dockerfile | Nginx-based container configuration for marketing site |
| apps/app/tsconfig.json | TypeScript configuration with Next.js plugin and path aliases |
| apps/app/tests/utils.ts | Comprehensive Playwright test utilities (2588 lines) |
| apps/app/src/types/session.ts | Session type definitions for agent conversations |
| apps/app/src/types/electron.d.ts | Electron API type definitions with comprehensive interfaces |
| apps/app/src/store/setup-store.ts | Zustand store for setup wizard state management |
| apps/app/src/store/app-store.ts | Main application Zustand store with persistence |
| apps/app/src/lib/utils.ts | Utility functions for CSS classes and model checking |
| apps/app/src/lib/project-init.ts | Project initialization utilities for .automaker directory |
| apps/app/src/lib/log-parser.ts | Agent output log parsing with structured entry types |
| apps/app/src/lib/electron.ts | Electron API wrapper with mock implementations (2293 lines) |
| apps/app/src/lib/agent-context-parser.ts | Agent context parsing for task extraction and progress tracking |
| apps/app/src/hooks/*.ts | Custom React hooks for various features |
| apps/app/src/components/views/setup-view/*/index.ts | Barrel exports for setup view components |
| apps/app/public/vercel.svg | Vercel logo SVG asset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Change default skipTests value from false to true (tests disabled by default) - Rename checkbox label from 'Skip automated testing' to 'Enable automated testing' - Invert checkbox logic so checked means tests enabled - Update help text to clarify the new behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Standardized quotes in YAML files for better readability. - Adjusted cache-dependency-path to point to the correct location. - Removed unnecessary working-directory specifications to simplify the workflow.
- Introduced a new command `dev:electron:debug` in both package.json files to launch Electron with DevTools open. - Updated main.js to conditionally open DevTools based on the `OPEN_DEVTOOLS` environment variable. - Refactored some IPC handler code for better readability and consistency.
The monorepo restructure caused npm to skip installing platform-specific optional dependencies for tailwindcss and lightningcss. This adds explicit dependencies for the Linux x64 binaries and removes the duplicate lockfile. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Added `geist` npm package for local font files - Updated layout.tsx to import fonts from the geist package - Build now succeeds without network access to Google Fonts Co-authored-by: GTheMachine <156854865+GTheMachine@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…d add optional flags - Removed `@tailwindcss/oxide-linux-x64-gnu` and `lightningcss-linux-x64-gnu` dependencies. - Added `dev` and `optional` flags for Linux x64 binaries to enhance compatibility.
Fix build issues by switching from Google Fonts to local fonts
- Removed unnecessary variable assignments for GeistSans and GeistMono. - Updated imports to directly use the Geist font components.
- Added `artifactName` template for output files. - Set `executableName` for the application to improve clarity in the build process.
No description provided.