Updated pom.xml. Minor comments fixes. Updated JSErrorsCollectorListe…

…ner.
AutomatedOwl · May 26, 2018 · 6eb1bc9 · 6eb1bc9
1 parent 53033bc
commit 6eb1bc9
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 8 deletions.
diff --git a/junit5/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorJUnit.java b/junit5/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorJUnit.java
@@ -6,7 +6,7 @@
 import java.lang.annotation.Target;
 import org.junit.jupiter.api.extension.ExtendWith;
 
-/** Java annotation for collection chromedriver JS errors using JUnit 5. */
+/** Java annotation for collecting chromedriver JS errors using JUnit 5. */
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.METHOD,ElementType.ANNOTATION_TYPE})
 @ExtendWith(JSErrorsExtension.class)

diff --git a/junit5/src/test/java/com/github/automatedowl/tools/JSCollectorJUnitTest.java b/junit5/src/test/java/com/github/automatedowl/tools/JSCollectorJUnitTest.java
@@ -1,6 +1,5 @@
 package com.github.automatedowl.tools;
 
-import com.github.automatedowl.tools.JSErrorsCollectorJUnit;
 import com.github.automatedowl.tools.drivers.junitholder.JSErrorsDriverHolder;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;

diff --git a/testng/pom.xml b/testng/pom.xml
@@ -45,11 +45,6 @@
         </pluginManagement>
     </build>
     <dependencies>
-        <dependency>
-            <groupId>org.junit.platform</groupId>
-            <artifactId>junit-platform-launcher</artifactId>
-            <version>1.2.0</version>
-        </dependency>
         <dependency>
             <groupId>org.seleniumhq.selenium</groupId>
             <artifactId>selenium-chrome-driver</artifactId>

diff --git a/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java b/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java
@@ -63,6 +63,7 @@ public void afterInvocation(IInvokedMethod iInvokedMethod, ITestResult iTestResu
             }
             else if (isAssertJSErrorsEnabled(
                     iInvokedMethod) && getJSErrorsFromLogEntries(logEntries).anyMatch(e -> true)) {
+                JSErrorsDriverHolder.getDriverForTest(iInvokedMethod.getTestMethod().getMethodName()).quit();
                 throw new WebDriverException(JS_ERRORS_EXCEPTION_STRING);
             }
         }

diff --git a/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorTestNG.java b/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorTestNG.java
@@ -5,7 +5,7 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-/** Java annotation for collection chromedriver JS errors using TestNG. */
+/** Java annotation for collecting chromedriver JS errors using TestNG. */
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.METHOD,ElementType.ANNOTATION_TYPE})
 public @interface JSErrorsCollectorTestNG {