Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve last error handling: Record the last_error closer to the queries so it's not lost and don't run 'SELECT FOUND_ROWS()' if the query has failed #156

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Jul 24, 2024

Improve last error handling: Record the last_error closer to the queries so it's not lost and don't run 'SELECT FOUND_ROWS()' if the query has failed

Sync https://plugins.trac.wordpress.org/changeset/3123906

…ies so it's not lost and don't run 'SELECT FOUND_ROWS()' if the query has failed

Sync https://plugins.trac.wordpress.org/changeset/3123906

Co-Authored-By: vnsavage <1204149+vnsavage@users.noreply.github.com>
Copy link

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared side by side, changes checks out! 👍

@sanmai sanmai requested a review from sjinks August 13, 2024 02:57
@dd32 dd32 merged commit e05ee70 into trunk Aug 13, 2024
4 checks passed
@dd32 dd32 deleted the merge/svn-3123906 branch August 13, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants