-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yarn and Better Document Dependencies #689
base: master
Are you sure you want to change the base?
Conversation
LGTM, maybe add some stuff to the .gitignore https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored oops, I sent that before just setup finished, I'm getting some errors that I wasn't before
|
This is because Yarn >=2.x no longer automatically runs pre and post scripts outside of set lifecycle scripts, so the tests aren't being built before Yarn tries to run them. We can remedy this by merging the "scripts": {
"watch:esbuild": "node esbuild.cjs --watch",
"watch:tsc": "tsc --noEmit --watch",
- "pretest": "yarn lint && tsc && node esbuild.cjs",
+ "test": "yarn lint && tsc && node esbuild.cjs && node build/tests/runTests.js",
"vscode:prepublish": "yarn lint && tsc --noEmit && node esbuild.cjs --production",
"package": "vsce package",
"lint": "eslint src --ext ts"
}, I'd do it myself but I don't think I have access to this branch to add changes so leaving the fix here. This should also fix the failing |
Co-authored-by: mcecode <mcecode@users.noreply.github.com>
1aae6e9
to
a25f82c
Compare
I just realized because of the failing test that a blocker in doing this Yarn migration is |
#688 informed me that Harper has been using an old (deprecated) version of Yarn. This PR updates the referenced Yarn version in our
package.json
files and modifies our tooling to work with it.I've also added a short blurb about certain integration test dependencies on certain Linux platforms.
@shanecranor, does this look good to you?