feat: move 'could of' etc from matcher.rs to its own linter
#715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the false positives brought to light in Automattic#681
hippietrail
changed the title
matcher.rs to its own linter
| } | ||
|
|
||
| #[test] | ||
| fn test_for_of() { |
There was a problem hiding this comment.
I would replace "test" with whether the rule should correct or allow the phrase.
For example: catches_missed_part. That way, the intent is better conveyed.
|
|
||
| #[test] | ||
| fn test_missed_part() { | ||
| assert_lint_count("Ah I must of missed that part.", ModalOf::default(), 1); |
There was a problem hiding this comment.
For test cases where the rule should match, try to use assert_suggestion_result instead.
| impl Default for ModalOf { | ||
| fn default() -> Self { | ||
| // Note 1. "shan't of" is plausible but very unlikely | ||
| // Note 2. "had of" has trickier false positives and is less common anyway |
There was a problem hiding this comment.
I like your priorities here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the false positives brought to light in #681