Overhaul

[elijah-potter]

There are a number of changes in here, all aimed towards refactoring Harper's core engine to be more faster, simpler, and more extensible.

The biggest change (so far) was to rework the LintGroup type to be runtime-extensible. This significantly reduces the number of types the Rust compiler must churn through and therefore significantly improves compile times.

Additionally, I've changed the naming conventions of the Harper lint setting keys. If you configure harper-ls through lspconfig, you may need change your settings to match the new schema (which will be outlined in our Neovim configuration documentation). In VSCode or Obsidian, you may have to reconfigure your setup. See #667 for why we are doing this.

I will also be updating the Rust version and removing a ton of boilerplate in Patterns.

The goal is to do as many wide-reaching changes in one PR, in order to pay back tech debt in a way that avoids merge conflicts.

[mcecode]

So are we settling on harper-ls.camelCase.PascalCase as the pattern for all of our configs now? If so, then the following also need to be updated for consistency's sake:

• harper-ls.codeActions.forceStable > harper-ls.codeActions.ForceStable
• harper-ls.markdown.ignore_link_title > harper-ls.markdown.IgnoreLinkTitle

---

As for the precommit workflow failing, it seems the order that diagnostics are sent has changed, maybe due to the changes in harper-core. So updating the second test from

	it('gives correct diagnostics', () => {
		compareActualVsExpectedDiagnostics(
			getActualDiagnostics(markdownUri),
			createExpectedDiagnostics(
				{
					message: 'Did you mean to repeat this word?',
					range: createRange(2, 39, 2, 48)
				},
				{
					message: 'Did you mean to spell “errorz” this way?',
					range: createRange(2, 26, 2, 32)
				}
			)
		);
	});

to

	it('gives correct diagnostics', () => {
		compareActualVsExpectedDiagnostics(
			getActualDiagnostics(markdownUri),
			createExpectedDiagnostics(
				{
					message: 'Did you mean to spell “errorz” this way?',
					range: createRange(2, 26, 2, 32)
				},
				{
					message: 'Did you mean to repeat this word?',
					range: createRange(2, 39, 2, 48)
				}
			)
		);
	});

should fix the issue.

---

Lastly, packages/vscode-plugin/src/tests/fixtures/.vscode/settings.json should also be updated to reflect the new changes. So it should be updated from

{
	"files.associations": { "git-commit": "git-commit" },
	"harper-ls.linters.spell_check": true,
	"harper-ls.linters.repeated_words": true,
}

to

{
	"files.associations": { "git-commit": "git-commit" },
	"harper-ls.linters.SpellCheck": true,
	"harper-ls.linters.RepeatedWords": true,
}

[elijah-potter]

You're absolutely right @mcecode. I've updated the keys to match. Thanks for looking into why those tests were failing :).