refactor: start splitting pronouns out of nouns #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippietrail
changed the title
hippietrail
force-pushed
the
noun-to-nominal
branch
from
19357c2 to
830a239
Compare
feat: pronoun now its own token kind & word metadata
s = subject case for pronouns o = object case for pronouns f = 1st person for pronouns n = 2nd person for pronouns t = 3rd person for pronouns c = comparative degree for adjectives u = superlative degree for adjectives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #730 this is the first step, moving the current "noun" types, which actually combine nouns and pronouns, into "nominal" types, that being the umbrella term in grammar/linguistics that encompasses both nouns and pronouns.
Because of the use of templates to derive type and function names from other type names, I had to rename a lot more identifiers than expected.
The next step will be to move pronouns out into their own type, with a "person" (1st/2nd/3rd) property but without a "proper" property.
Then noun can also be moved out, keeping things that apply to both, such as "nominal phrase" inside but things that don't such as "compound noun" outside the "nominal" type and inside the "noun" type.
This will make it easier to differentiate linters that work only on pronouns or only one nouns from those that work on both.