Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): added plural form of integration #740

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ficcdaf
Copy link
Contributor

@ficcdaf ficcdaf commented Feb 21, 2025

This pr adds the plural of integration -> integrations to the dictionary. Here are the new expansions of the word:

image

I thought reintegrations and disintegrations seem a little weird. disintegrations is listed as a plural of disintegration on merriam-webster so I think that's fine, but reintegrations is not listed as a word. Chat-GPT says it's correct and refers to "multiple instances of something being restored or brought back together", but I'm not sure how reliable that is haha. Opening this as a draft until we can decide.

@hippietrail
Copy link
Contributor

This pr adds the plural of integration -> integrations to the dictionary. Here are the new expansions of the word:

image

I thought reintegrations and disintegrations seem a little weird. disintegrations is listed as a plural of disintegration on merriam-webster so I think that's fine, but reintegrations is not listed as a word. Chat-GPT says it's correct and refers to "multiple instances of something being restored or brought back together", but I'm not sure how reliable that is haha. Opening this as a draft until we can decide.

When you're not sure if something is really a word or if it's actually used, try a Google search with it in quotes. For finding relevant techy examples I often put site:github.com OR site:medium.com OR site:slashdot.com and for checking if it's in any reputable dictionary cambridge OR collins OR oed OR oxford OR websters OR wiktionary

@ficcdaf
Copy link
Contributor Author

ficcdaf commented Feb 21, 2025

Ok. Thanks for the tip, and reintegrations does appear in a few dictionaries. In that case this is ready for review. Not sure why precommit is failing, I think something's going on with the CI in the master branch

@ficcdaf ficcdaf marked this pull request as ready for review February 21, 2025 23:07
@hippietrail
Copy link
Contributor

Ok. Thanks for the tip, and reintegrations does appear in a few dictionaries. In that case this is ready for review. Not sure why precommit is failing, I think something's going on with the CI in the master branch

Feels like a cromulent word to me too, especially in the dev realm. I often get recommits failing temporarily but this one looks different. I don't understand much of that stuff though 🫤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants