Boost: Remove URL override from image guide (#39874)

Co-authored-by: Peter Petrov <peter.petrov89@gmail.com>
Automattic · Oct 23, 2024 · c3e2ec5 · c3e2ec5
1 parent 2599f56
commit c3e2ec5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/projects/plugins/boost/.phan/baseline.php b/projects/plugins/boost/.phan/baseline.php
@@ -30,7 +30,6 @@
     // PhanImpossibleTypeComparison : 1 occurrence
     // PhanImpossibleTypeComparisonInGlobalScope : 1 occurrence
     // PhanPluginNeverReturnFunction : 1 occurrence
-    // PhanPluginSimplifyExpressionBool : 1 occurrence
     // PhanRedefineFunction : 1 occurrence
     // PhanTypeComparisonToArray : 1 occurrence
     // PhanTypeInvalidUnaryOperandIncOrDec : 1 occurrence
@@ -62,7 +61,6 @@
         'app/lib/minify/functions-helpers.php' => ['PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchArgumentNullableInternal', 'PhanTypeMismatchDefault', 'PhanUndeclaredClassMethod', 'PhanUndeclaredClassReference', 'PhanUndeclaredConstant'],
         'app/lib/minify/functions-service.php' => ['PhanImpossibleTypeComparison', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanPluginNeverReturnFunction', 'PhanPluginUseReturnValueInternalKnown', 'PhanPossiblyUndeclaredVariable', 'PhanRedundantCondition', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchArgumentNullableInternal'],
         'app/modules/Modules_Setup.php' => ['PhanTypeMismatchPropertyDefault'],
-        'app/modules/image-guide/Image_Guide.php' => ['PhanPluginSimplifyExpressionBool'],
         'app/modules/image-guide/Image_Guide_Proxy.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],
         'app/modules/image-size-analysis/data-sync/Image_Size_Analysis_Action_Fix.php' => ['PhanPossiblyUndeclaredVariable', 'PhanRedundantCondition'],
         'app/modules/optimizations/critical-css/CSS_Proxy.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],

diff --git a/projects/plugins/boost/app/modules/image-guide/Image_Guide.php b/projects/plugins/boost/app/modules/image-guide/Image_Guide.php
@@ -9,15 +9,12 @@
 class Image_Guide implements Pluggable {
 
 	public function setup() {
-		// phpcs:ignore WordPress.Security.NonceVerification.Recommended
-		$override = isset( $_GET['jb-debug-ig'] );
-
-		if ( is_admin() || is_user_logged_in() || current_user_can( 'manage_options' ) ) {
+		if ( is_user_logged_in() && current_user_can( 'manage_options' ) ) {
 			Image_Guide_Proxy::init();
 		}
 
 		// Show the UI only when the user is logged in, with sufficient permissions and isn't looking at the dashboard.
-		if ( true !== $override && ( is_admin() || ! is_user_logged_in() || ! current_user_can( 'manage_options' ) ) ) {
+		if ( is_admin() || ! is_user_logged_in() || ! current_user_can( 'manage_options' ) ) {
 			return;
 		}
 

diff --git a/projects/plugins/boost/changelog/remove-image-guide-override b/projects/plugins/boost/changelog/remove-image-guide-override
@@ -0,0 +1,4 @@
+Significance: minor
+Type: removed
+
+Image Guide: Remove URL parameter based override.