-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: Ensure form choice buttons have a fallback text color if text and background are the same #39789
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! That looks like Twenty Twenty, and it seems to be the case for Twenty Fifteen as well on Simple, but not Twenty Fourteen (all had the same issue originally where no text displayed). I think it makes sense to fix that in this PR as it does introduce it with the text color change in those cases. |
Fixes https://github.com/Automattic/vulcan/issues/539
Proposed changes:
Other information:
Jetpack product discussion
https://github.com/Automattic/vulcan/issues/539
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Self-hosted:
WoA:
Simple:
Screenshots to demo the difference
Twenty Twenty before:
Twenty Twenty after: