Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Initial State: Migrate URLs in the editor #39799

Merged

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Oct 17, 2024

Extracted out of #38983 to split it into smaller PRs.

Proposed changes:

  • Migrate URLs in the editor to the new script data

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • On a Jetpack site, login as an author, without a user connection
  • Goto editor
  • Open Social panel
  • Confirm that the user connection link works as expected.
    image
  • Now connect the user account.
  • Now for Jetpack, Simple and Atomic sites, goto the editor
  • Confirm that the connection management links/buttons work fine
  • Try to break a connection, for example, if you have Facebbok or Instagram connection, remove Jetpack from here to break the connection.
  • In the editor, confirm that the broken connection link points to connections manage UI for Jetpack site and to the Calypso connections management for WPCOM sites
  • Likewise test that an unsupported connection link works fine, if you have one.

@manzoorwanijk manzoorwanijk self-assigned this Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-initial-state/migrate-urls-in-editor branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-initial-state/migrate-urls-in-editor
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for November 5, 2024 (scheduled code freeze on November 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@manzoorwanijk manzoorwanijk force-pushed the update/social-initial-state/migrate-urls-in-editor branch from 0e1445a to e3337b6 Compare October 17, 2024 07:26
@manzoorwanijk manzoorwanijk changed the base branch from trunk to update/social-initial-state/migrate-urls-on-social-admin October 17, 2024 07:26
@manzoorwanijk manzoorwanijk requested a review from a team October 17, 2024 07:26
@manzoorwanijk manzoorwanijk marked this pull request as ready for review October 17, 2024 07:26
@github-actions github-actions bot added [Status] In Progress [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin labels Oct 17, 2024
@manzoorwanijk manzoorwanijk force-pushed the update/social-initial-state/migrate-urls-in-editor branch from c04acb0 to 1045121 Compare October 17, 2024 08:26
Base automatically changed from update/social-initial-state/migrate-urls-on-social-admin to trunk October 18, 2024 08:42
@manzoorwanijk manzoorwanijk force-pushed the update/social-initial-state/migrate-urls-in-editor branch from 1045121 to 98ea0e3 Compare October 18, 2024 08:43
@manzoorwanijk manzoorwanijk merged commit c82adbd into trunk Oct 18, 2024
59 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social-initial-state/migrate-urls-in-editor branch October 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants