Forms: version iAPI modules with asset file hash instead of Jetpack version #45193

simison · 2025-09-16T10:45:18Z

Resolves FORMS-287

Alternative to #45169

Proposed changes:

Adds util pulling a version from the generated view.asset.php file, falling back to Jetpack version
Use the new util in all iAPI modules for Forms

Before

After

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Test forms frontend, check that file gets cache-busted with the hash found in the generated view.asset.php files
Test multi step forms
Test slider, rating, file upload, and phone fields

github-actions · 2025-09-16T10:46:08Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-version-modules-with-asset-file branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-version-modules-with-asset-file

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-09-16T10:46:16Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-09-16T10:54:29Z

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-field.php	1075/1679 (64.03%)	-0.12%	2 ❤️‍🩹
projects/packages/forms/src/contact-form/class-util.php	42/170 (24.71%)	1.68%	1 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	424/1302 (32.57%)	0.07%	-3 💚
projects/packages/forms/src/contact-form/class-contact-form.php	585/1090 (53.67%)	0.15%	-3 💚

Full summary · PHP report · JS report

simison · 2025-09-16T10:56:29Z

projects/packages/forms/src/contact-form/class-util.php

+	 * @param string $asset_file Path to view.asset.php file.
+	 * @return string either asset hash or Jetpack version.
+	 */
+	public static function get_view_asset_version( $asset_file ) {


I could see this in Jetpack main plugin's Assets package as well.

Why view in the method name? Won't it work for any assets.php file?

Yep! It does.

I'm thinking of renaming to better highlight the intent of using alongside wp_enqueue_script_module(). Or just leave it generic.

simison · 2025-09-16T10:56:52Z

projects/packages/forms/src/contact-form/class-util.php

+	 */
+	public static function get_view_asset_version( $asset_file ) {
+		$asset           = file_exists( $asset_file ) ? require $asset_file : null;
+		$jetpack_version = Constants::get_constant( 'JETPACK__VERSION' );


Alternatively we could fail loudly instead of falling back to JP version; now if the path is incorrect for example, dev might not notice.

Failing when we actually expect the file to exist is better IMHO.

projects/packages/forms/src/contact-form/class-contact-form-field.php

projects/packages/forms/src/contact-form/class-util.php

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

simison · 2025-09-16T12:00:14Z

Another consideration; in earlier PR we had used similar generated version for each asset, but we really need it only for modules. Should we use it everywhere or just focus on fields with modules?

simison requested a review from a team September 16, 2025 10:45

simison added [Status] Needs Review This PR is ready for review. [Package] Forms [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Sep 16, 2025

simison requested a review from manzoorwanijk September 16, 2025 10:46

github-actions bot added [Feature] Contact Form [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Sep 16, 2025

simison commented Sep 16, 2025

View reviewed changes

projects/packages/forms/src/contact-form/class-contact-form-field.php Outdated Show resolved Hide resolved

simison added 3 commits September 16, 2025 14:24

Forms: conslidate asset versioning for Forms iAPI modules

e9a61c9

changelog

d360496

Fix two paths

363abbe

simison force-pushed the update/forms-version-modules-with-asset-file branch from 5d96c9b to 363abbe Compare September 16, 2025 11:25

manzoorwanijk reviewed Sep 16, 2025

View reviewed changes

projects/packages/forms/src/contact-form/class-util.php Outdated Show resolved Hide resolved

Update projects/packages/forms/src/contact-form/class-util.php

fa1b86f

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: version iAPI modules with asset file hash instead of Jetpack version #45193

Forms: version iAPI modules with asset file hash instead of Jetpack version #45193

simison commented Sep 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

simison Sep 16, 2025

Uh oh!

manzoorwanijk Sep 16, 2025

Uh oh!

simison Sep 16, 2025

Uh oh!

simison Sep 16, 2025

Uh oh!

manzoorwanijk Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

simison commented Sep 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Forms: version iAPI modules with asset file hash instead of Jetpack version #45193

Are you sure you want to change the base?

Forms: version iAPI modules with asset file hash instead of Jetpack version #45193

Conversation

simison commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Before

After

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

simison Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

simison Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

simison Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

simison commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

simison commented Sep 16, 2025 •

edited

Loading

github-actions bot commented Sep 16, 2025 •

edited

Loading

github-actions bot commented Sep 16, 2025 •

edited

Loading

jp-launch-control bot commented Sep 16, 2025 •

edited

Loading

simison commented Sep 16, 2025 •

edited

Loading