Charts: Add global context utility for getting styles for any chart component #45207

adamwoodnz · 2025-09-17T04:58:16Z

Fixes CHARTS-111: Charts: Add hook to get the styles for any chart component

Proposed changes:

Adds getElementStyles method to the global charts context, which can provide all the possible styles for an element; color, lineStyles, glyph, legend shape...
This replaces usages of resolveGroupColor (which becomes the internal resolveColor utility), and getters for glyphs, shapes, line styles...

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Go to '..'

github-actions · 2025-09-17T04:59:06Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-09-17T04:59:15Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-09-17T05:31:39Z

Code Coverage Summary

Coverage changed in 5 files.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/charts/src/components/legend/hooks/use-chart-legend-items.ts	31/38 (81.58%)	-0.77%	1 ❤️‍🩹
projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx	71/77 (92.21%)	-0.20%	0 💚
projects/js-packages/charts/src/components/legend/private/base-legend.tsx	18/18 (100.00%)	0.00%	0 💚
projects/js-packages/charts/src/components/line-chart/line-chart.tsx	99/105 (94.29%)	-0.11%	0 💚
projects/js-packages/charts/src/providers/chart-context/global-charts-provider.tsx	37/37 (100.00%)	0.00%	0 💚

Full summary · PHP report · JS report

adamwoodnz · 2025-09-18T00:24:04Z

projects/js-packages/charts/src/providers/chart-context/themes.ts

@@ -151,6 +151,15 @@ const wooTheme: ChartTheme = {
 	legendContainerStyles: {
 		gap: '8px',
 	},
+	legendShapeStyles: [


Copied from Woo Analytics. We should be able to remove it there after this is shipped

adamwoodnz · 2025-09-18T00:27:11Z

projects/js-packages/charts/src/components/legend/hooks/use-chart-legend-items.ts

-				renderGlyph,
-			};
+		if ( withGlyph ) {
+			const glyphToUse = renderGlyph || glyph;


This support for legend glyphs isn't working yet

adamwoodnz · 2025-09-18T00:28:11Z

projects/js-packages/charts/src/components/legend/hooks/use-chart-legend-items.ts

-
-			return itemWithGlyph;
+		if ( withGlyph ) {
+			const glyphToUse = renderGlyph || glyph;


This support for legend glyphs isn't working yet

adamwoodnz added 3 commits September 17, 2025 15:06

Use a constant for chart types

ec8b29b

Add getElementStyles method with color and lineStyles properties

cf32104

Add changelog

f0db3cd

adamwoodnz self-assigned this Sep 17, 2025

github-actions bot added [JS Package] Charts [Status] In Progress [Tests] Includes Tests RNA labels Sep 17, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 17, 2025

adamwoodnz added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Sep 17, 2025

adamwoodnz added 7 commits September 18, 2025 09:58

Revert adding chartType

01ed5cc

Revert adding chart type constant

8bcfbf4

Remove resolveGroupColor from context value

cc34adc

Allow for data options stroke color

f26958b

Add glyph

648a728

Simplify resolveColor

eb2ac14

Fix global context tests

6b1fe74

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch from 7b071d9 to 6b1fe74 Compare September 17, 2025 21:58

Use getElementStyles in useChartLegendItems

a57df8c

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch from fb8e3de to 6fbf3ca Compare September 17, 2025 23:30

Update legend stories to use different shapes

9180049

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch from 6fbf3ca to 9180049 Compare September 17, 2025 23:31

Copy legendShapeStyles from WA into Woo theme

5def5a0

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch from 764565e to 94d121d Compare September 18, 2025 00:22

adamwoodnz commented Sep 18, 2025

View reviewed changes

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch from 94d121d to a4da715 Compare September 18, 2025 00:29

Revert removal of legend shape styles handling

7627929

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch 2 times, most recently from 6e3a973 to e37b8e9 Compare September 18, 2025 00:41

Remove override color from pie charts

a623766

adamwoodnz force-pushed the charts-111-charts-add-hook-to-get-the-styles-for-any-chart-component branch from e37b8e9 to a623766 Compare September 18, 2025 00:43

Simplify getItemShapeStyles return type

276f12e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Charts: Add global context utility for getting styles for any chart component #45207

Charts: Add global context utility for getting styles for any chart component #45207

adamwoodnz commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

adamwoodnz Sep 18, 2025

Uh oh!

adamwoodnz Sep 18, 2025 •

edited

Loading

Uh oh!

adamwoodnz Sep 18, 2025

Uh oh!

Uh oh!

Charts: Add global context utility for getting styles for any chart component #45207

Are you sure you want to change the base?

Charts: Add global context utility for getting styles for any chart component #45207

Conversation

adamwoodnz commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

adamwoodnz Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

adamwoodnz Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamwoodnz Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adamwoodnz commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading

jp-launch-control bot commented Sep 17, 2025 •

edited

Loading

adamwoodnz Sep 18, 2025 •

edited

Loading